[GitHub] [incubator-pekko] raboof commented on a diff in pull request #319: Integrate sbt-license-report

["raboof (via GitHub)" <gi...@apache.org>]

raboof commented on code in PR #319:
URL: https://github.com/apache/incubator-pekko/pull/319#discussion_r1193608307


##########
project/Dependencies.scala:
##########
@@ -75,44 +75,44 @@ object Dependencies {
   object Compile {
     // Compile
 
-    val config = "com.typesafe" % "config" % "1.4.2" // ApacheV2
-    val netty = "io.netty" % "netty" % nettyVersion // ApacheV2
+    val config = "com.typesafe" % "config" % "1.4.2"

Review Comment:
   These are occasionally useful when deciding whether it's OK to use a Test dependency as a Compile dependency as well, or to check whether an upstream license change was carefully considered. I'm OK with dropping them though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org