[jira] [Commented] (YUNIKORN-1102) shim context getTask error is ignored

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499882#comment-17499882 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1102:
-------------------------------------------------

As a side node: {{GetApplication}} can be simplified to just this:
{code:java}
func (ctx *Context) GetApplication(appID string) interfaces.ManagedApp {
   ctx.lock.RLock()
   defer ctx.lock.RUnlock()
   return ctx.applications[appID]
}{code}
No need to have an if construct to check for existence

> shim context getTask error is ignored
> -------------------------------------
>
>                 Key: YUNIKORN-1102
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1102
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Priority: Major
>              Labels: newbie
>
> The {{context.getTask()}} call returns a {{Task}} struct and an error. In all cases either the task is nil or the error is nil. The error returned is also fixed and does not provide any detail not known without it (i.e. "application is not found" which only partially covers the cases)
> We need to bring the call in line with _GetApplication_ and the _GetNode_ in the cache and just return the task and handle the nil return.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org