You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/05/09 08:51:44 UTC

Review Request 59083: Added resource provider actions.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59083/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jie Yu.


Repository: mesos


Description
-------

Added resource provider actions.


Diffs
-----

  include/mesos/resource_provider/resource_provider.proto 0efef33010d53c3f0098e70ad5c626b9b69bcc1a 


Diff: https://reviews.apache.org/r/59083/diff/1/


Testing
-------

make check


Thanks,

Jan Schlicht


Re: Review Request 59083: Added resource provider actions.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59083/
-----------------------------------------------------------

(Updated May 9, 2017, 1:06 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-7336
    https://issues.apache.org/jira/browse/MESOS-7336


Repository: mesos


Description
-------

Added resource provider actions.


Diffs
-----

  include/mesos/resource_provider/resource_provider.proto 0efef33010d53c3f0098e70ad5c626b9b69bcc1a 
  include/mesos/v1/resource_provider/resource_provider.proto 82e6741d96cf1005b1398fb6453cf2a899583c9f 


Diff: https://reviews.apache.org/r/59083/diff/3/


Testing
-------

make check


Thanks,

Jan Schlicht


Re: Review Request 59083: Added resource provider actions.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59083/#review174301
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On May 9, 2017, 9:40 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59083/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 9:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added resource provider actions.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto 0efef33010d53c3f0098e70ad5c626b9b69bcc1a 
>   include/mesos/v1/resource_provider/resource_provider.proto 82e6741d96cf1005b1398fb6453cf2a899583c9f 
> 
> 
> Diff: https://reviews.apache.org/r/59083/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 59083: Added resource provider actions.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59083/
-----------------------------------------------------------

(Updated May 9, 2017, 11:40 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Added missing import.


Repository: mesos


Description
-------

Added resource provider actions.


Diffs (updated)
-----

  include/mesos/resource_provider/resource_provider.proto 0efef33010d53c3f0098e70ad5c626b9b69bcc1a 
  include/mesos/v1/resource_provider/resource_provider.proto 82e6741d96cf1005b1398fb6453cf2a899583c9f 


Diff: https://reviews.apache.org/r/59083/diff/3/

Changes: https://reviews.apache.org/r/59083/diff/2-3/


Testing
-------

make check


Thanks,

Jan Schlicht


Re: Review Request 59083: Added resource provider actions.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59083/
-----------------------------------------------------------

(Updated May 9, 2017, 11:37 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Added changes to v1 proto.


Repository: mesos


Description
-------

Added resource provider actions.


Diffs (updated)
-----

  include/mesos/resource_provider/resource_provider.proto 0efef33010d53c3f0098e70ad5c626b9b69bcc1a 
  include/mesos/v1/resource_provider/resource_provider.proto 82e6741d96cf1005b1398fb6453cf2a899583c9f 


Diff: https://reviews.apache.org/r/59083/diff/2/

Changes: https://reviews.apache.org/r/59083/diff/1-2/


Testing
-------

make check


Thanks,

Jan Schlicht


Re: Review Request 59083: Added resource provider actions.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59083/#review174281
-----------------------------------------------------------



Can you update v1 API as well?

- Jie Yu


On May 9, 2017, 8:51 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59083/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 8:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added resource provider actions.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto 0efef33010d53c3f0098e70ad5c626b9b69bcc1a 
> 
> 
> Diff: https://reviews.apache.org/r/59083/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>