You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2014/12/16 20:28:59 UTC

[GitHub] incubator-flink pull request: Improvement on Type Hints for Java A...

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/incubator-flink/pull/270

    Improvement on Type Hints for Java API

    This buils upon pull request #203 by @twalthr 
    The additions here are
     - Make MissingTypeInfo optional in TypeExtractor (by default still throws exception)
     - Simplified deferred evaluation of type dependend code by making evaluations lazy
     - Add call location function names to MissingTypeInfo error messages.
     - Improvements on other error messages.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink typeHints

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #270
    
----
commit fb96f12aa6515e0abf7dbd658bb1068b8ac63a15
Author: Stephan Ewen <se...@apache.org>
Date:   2014-12-16T19:24:06Z

    [Java API] Fix equality checks on PojoTypeInfo

commit 3c8f320a3d4e55abbe5758a756a84a40ea7cdca0
Author: twalthr <in...@twalthr.com>
Date:   2014-11-07T15:18:23Z

    [FLINK-1245] [Java API] Introduce TypeHints for Java API operators

commit 71452f167003359a18255fdb94446d1947e9dcf3
Author: twalthr <in...@twalthr.com>
Date:   2014-12-15T20:43:05Z

    [FLINK-1245] [Java API] Introduce MissingTypeInfo
    
    This closes #203

commit 147ee9ebab24f7ee67ef5f877d451f0072d65c2d
Author: Stephan Ewen <se...@apache.org>
Date:   2014-12-16T15:55:24Z

    [FLINK-1245] [Java API] Vasious additions to the TypeInformation hinting code
    
     - Make MissingTypeInfo optional in TypeExtractor (by default still throws exception)
     - Simplified deferred evaluation of type dependend code by making evaluations lazy
     - Add call location function names to MissingTypeInfo error messages.
     - Improvements on other error messages.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Improvement on Type Hints for Java A...

Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:

    https://github.com/apache/incubator-flink/pull/270#issuecomment-67279101
  
    I reviewed the code. The changes look reasonable. Is there a need to introduce TypeHints also for the Streaming API?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Improvement on Type Hints for Java A...

Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:

    https://github.com/apache/incubator-flink/pull/270#issuecomment-67279136
  
    I will close #203.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---