Re: [I] A chart's stored query_context is never migrated, so every non-Explore path 500s on charts saved by an older version [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on issue #42926:
URL: https://github.com/apache/superset/issues/42926#issuecomment-5594444196

   @AryaKetanShCt circling back on symptom 2, since #42927 only covered the first one. I dug into it a bit: the inference in `query_context_factory.py` only kicks in when there's an adhoc x-axis plus a temporal range filter, so a legacy chart that still carries its time column as `granularity_sqla` in `params` never hits it and lands on the raise in `models/helpers.py` instead. My take is that when the query object has `is_timeseries` and no `granularity`, we should fall back to `form_data`'s `granularity_sqla` (and only then the dataset's main datetime column), since that's what Explore effectively does when it rebuilds the query. Happy to be talked out of that. If you're still up for sending it with a test that replays an old-style `query_context`, go for it and link this issue. If not, say the word and I'll take it. Leaving this open until it lands.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org