You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Rick Curtis (JIRA)" <ji...@apache.org> on 2010/09/16 23:14:32 UTC
[jira] Created: (OPENJPA-1801) CacheStatistics misses are
improperly calculated.
CacheStatistics misses are improperly calculated.
-------------------------------------------------
Key: OPENJPA-1801
URL: https://issues.apache.org/jira/browse/OPENJPA-1801
Project: OpenJPA
Issue Type: Bug
Components: datacache
Affects Versions: 2.0.1, 2.1.0
Reporter: Rick Curtis
Assignee: Rick Curtis
Fix For: 2.1.0
In doing some testing I found that the DataCache statistics aren't calculated properly. In the case where there is a cache miss for a specific Type(Person.class), a miss (a read with no subsequent hit) is recorded for java.lang.Object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OPENJPA-1801) CacheStatistics misses are
improperly calculated.
Posted by "Rick Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Curtis reassigned OPENJPA-1801:
------------------------------------
Assignee: Rick Curtis
> CacheStatistics misses are improperly calculated.
> -------------------------------------------------
>
> Key: OPENJPA-1801
> URL: https://issues.apache.org/jira/browse/OPENJPA-1801
> Project: OpenJPA
> Issue Type: Bug
> Components: datacache
> Affects Versions: 2.0.1, 2.1.0
> Reporter: Rick Curtis
> Assignee: Rick Curtis
> Fix For: 2.1.0
>
>
> In doing some testing I found that the DataCache statistics aren't calculated properly. In the case where there is a cache miss for a specific Type(Person.class), a miss (a read with no subsequent hit) is recorded for java.lang.Object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1801) CacheStatistics misses are
improperly calculated.
Posted by "Pinaki Poddar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918238#action_12918238 ]
Pinaki Poddar commented on OPENJPA-1801:
----------------------------------------
from JavaDoc of CacheStatistics
* All methods with Class as input argument treats null as
* <code>java.lang.Object</code>. All per-class statistics depends on
* determining the runtime type of the instance being cached. If it is not
* possible to determine the runtime type from the given context, the statistics
* is registered under generic <code>java.lang.Object</code>.
*
* @since 1.3.0
> CacheStatistics misses are improperly calculated.
> -------------------------------------------------
>
> Key: OPENJPA-1801
> URL: https://issues.apache.org/jira/browse/OPENJPA-1801
> Project: OpenJPA
> Issue Type: Bug
> Components: datacache
> Affects Versions: 2.0.1, 2.1.0
> Reporter: Rick Curtis
> Assignee: Rick Curtis
> Fix For: 2.1.0
>
>
> In doing some testing I found that the DataCache statistics aren't calculated properly. In the case where there is a cache miss for a specific Type(Person.class), a miss (a read with no subsequent hit) is recorded for java.lang.Object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1801) CacheStatistics misses are
improperly calculated.
Posted by "Rick Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926325#action_12926325 ]
Rick Curtis commented on OPENJPA-1801:
--------------------------------------
The last commit for this JIRA(1028808) is actually for OPENJPA-1844.
> CacheStatistics misses are improperly calculated.
> -------------------------------------------------
>
> Key: OPENJPA-1801
> URL: https://issues.apache.org/jira/browse/OPENJPA-1801
> Project: OpenJPA
> Issue Type: Bug
> Components: datacache
> Affects Versions: 2.0.1, 2.1.0
> Reporter: Rick Curtis
> Assignee: Rick Curtis
> Fix For: 2.1.0
>
>
> In doing some testing I found that the DataCache statistics aren't calculated properly. In the case where there is a cache miss for a specific Type(Person.class), a miss (a read with no subsequent hit) is recorded for java.lang.Object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OPENJPA-1801) CacheStatistics misses are
improperly calculated.
Posted by "Rick Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Curtis resolved OPENJPA-1801.
----------------------------------
Resolution: Fixed
Committed changes to trunk. First off, this is a pretty major refactor and cache statistics collection isn't 100% yet. Unfortunately I don't have the time to test this as thoroughly as I would like. This is a step in the right direction and is more correct that the previous implementation, but it is still incomplete.
> CacheStatistics misses are improperly calculated.
> -------------------------------------------------
>
> Key: OPENJPA-1801
> URL: https://issues.apache.org/jira/browse/OPENJPA-1801
> Project: OpenJPA
> Issue Type: Bug
> Components: datacache
> Affects Versions: 2.0.1, 2.1.0
> Reporter: Rick Curtis
> Assignee: Rick Curtis
> Fix For: 2.1.0
>
>
> In doing some testing I found that the DataCache statistics aren't calculated properly. In the case where there is a cache miss for a specific Type(Person.class), a miss (a read with no subsequent hit) is recorded for java.lang.Object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1801) CacheStatistics misses are
improperly calculated.
Posted by "Rick Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Curtis updated OPENJPA-1801:
---------------------------------
Assignee: (was: Rick Curtis)
> CacheStatistics misses are improperly calculated.
> -------------------------------------------------
>
> Key: OPENJPA-1801
> URL: https://issues.apache.org/jira/browse/OPENJPA-1801
> Project: OpenJPA
> Issue Type: Bug
> Components: datacache
> Affects Versions: 2.0.1, 2.1.0
> Reporter: Rick Curtis
> Fix For: 2.1.0
>
>
> In doing some testing I found that the DataCache statistics aren't calculated properly. In the case where there is a cache miss for a specific Type(Person.class), a miss (a read with no subsequent hit) is recorded for java.lang.Object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1801) CacheStatistics misses are
improperly calculated.
Posted by "Rick Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918510#action_12918510 ]
Rick Curtis commented on OPENJPA-1801:
--------------------------------------
@Pinaki -
I came across that javadoc after I opened this JIRA, but I think in the code that I replaced we could have determined done a better job at determining the runtime type that was being cached. Either way I think we're in a better place than what we were.
I'm not sure if you looked at the changes I made, but from a high level I moved statistics calculation from the DataCache level up to the (DataCache)StoreManager level. I did this because only the StoreManager knows when a hit is really a hit.
> CacheStatistics misses are improperly calculated.
> -------------------------------------------------
>
> Key: OPENJPA-1801
> URL: https://issues.apache.org/jira/browse/OPENJPA-1801
> Project: OpenJPA
> Issue Type: Bug
> Components: datacache
> Affects Versions: 2.0.1, 2.1.0
> Reporter: Rick Curtis
> Assignee: Rick Curtis
> Fix For: 2.1.0
>
>
> In doing some testing I found that the DataCache statistics aren't calculated properly. In the case where there is a cache miss for a specific Type(Person.class), a miss (a read with no subsequent hit) is recorded for java.lang.Object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.