You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2025/06/13 15:41:20 UTC
(commons-jelly) 02/24: Use final
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jelly.git
commit 3f4f457a9a1913880ec0b353e4a706842146824d
Author: Gary D. Gregory <ga...@gmail.com>
AuthorDate: Fri Jun 13 11:27:09 2025 -0400
Use final
Sort members
---
.../commons/jelly/tags/junit/AbstractJellyTestSuite.java | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/jelly-tags/junit/src/main/java/org/apache/commons/jelly/tags/junit/AbstractJellyTestSuite.java b/jelly-tags/junit/src/main/java/org/apache/commons/jelly/tags/junit/AbstractJellyTestSuite.java
index 8059efb7..74b22e4c 100644
--- a/jelly-tags/junit/src/main/java/org/apache/commons/jelly/tags/junit/AbstractJellyTestSuite.java
+++ b/jelly-tags/junit/src/main/java/org/apache/commons/jelly/tags/junit/AbstractJellyTestSuite.java
@@ -18,13 +18,13 @@ package org.apache.commons.jelly.tags.junit;
import java.net.URL;
-import junit.framework.TestSuite;
-
import org.apache.commons.jelly.JellyContext;
import org.apache.commons.jelly.XMLOutput;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
+import junit.framework.TestSuite;
+
/**
* An abstract base class for creating a TestSuite via a Jelly script.
*/
@@ -47,8 +47,8 @@ public abstract class AbstractJellyTestSuite {
* @param script is the name of the script, which is typically just a name, no directory.
* @return a newly created TestSuite
*/
- public static TestSuite createTestSuite(Class testClass, String script) throws Exception {
- URL url = testClass.getResource(script);
+ public static TestSuite createTestSuite(final Class testClass, final String script) throws Exception {
+ final URL url = testClass.getResource(script);
if ( url == null ) {
throw new Exception(
"Could not find Jelly script: " + script
@@ -64,11 +64,11 @@ public abstract class AbstractJellyTestSuite {
* @param script is the URL to the script which should create a TestSuite
* @return a newly created TestSuite
*/
- public static TestSuite createTestSuite(URL script) throws Exception {
+ public static TestSuite createTestSuite(final URL script) throws Exception {
JellyContext context = new JellyContext(script);
- XMLOutput output = XMLOutput.createXMLOutput(System.out);
+ final XMLOutput output = XMLOutput.createXMLOutput(System.out);
context = context.runScript(script, output);
- TestSuite answer = (TestSuite) context.getVariable("org.apache.commons.jelly.junit.suite");
+ final TestSuite answer = (TestSuite) context.getVariable("org.apache.commons.jelly.junit.suite");
if ( answer == null ) {
log.warn( "Could not find a TestSuite created by Jelly for the script:" + script );
// return an empty test suite