[lucy-issues] [jira] [Commented] (CLOWNFISH-40) LockFreeRegistry should be private

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOWNFISH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531951#comment-14531951 ] 

ASF GitHub Bot commented on CLOWNFISH-40:
-----------------------------------------

GitHub user rectang opened a pull request:

    https://github.com/apache/lucy-clownfish/pull/15

    CLOWNFISH-40 Make LockFreeRegistry private

    LockFreeRegistry is needed only to achieve thread-safety for the Clownfish class registry; it should not be publicly exposed.
    
    Furthermore, it should be implemented in plain C and without using Clownfish object system features in order to simplify bootstrapping.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rectang/lucy-clownfish CLOWNFISH-40-lfreg-private

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy-clownfish/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 09ab2796242c19409a74964f4ae8630dbb09ec2b
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-05-07T03:05:42Z

    Change LockFreeRegistry from Clownfish to pure C.
    
    Remove the Clownfish object underpinnings from LockFreeRegistry, so that
    it becomes an ordinary C object.  Remove most bindings, so that it is
    only visible to the C core.
    
    The disabled Perl test remains in place, awaiting porting to C.

commit aaa9029554303dbe3339b6ac1e4eda3be322d8c4
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-05-07T03:18:15Z

    Downcase LFReg routines to indicate pure C.
    
    Replace Clownfish-method style capitalization with lowercasing to
    connote that they are inert functions.

commit e5b3bf5697994bc9078f6c4c2597e1a4966bf4cb
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-05-07T03:46:30Z

    Purge superficial trappings of Obj from LFReg.

----


> LockFreeRegistry should be private
> ----------------------------------
>
>                 Key: CLOWNFISH-40
>                 URL: https://issues.apache.org/jira/browse/CLOWNFISH-40
>             Project: Apache Lucy-Clownfish
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.5.0
>
>
> LockFreeRegistry is needed only to achieve thread-safety for the Clownfish class registry; it should not be publicly exposed.
> Furthermore, it should be implemented in plain C and without using Clownfish object system features in order to simplify bootstrapping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)