You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2023/12/11 07:11:06 UTC
[PR] Provide relevant nativeTest and corresponding GraalVM Reachability Metadata for MySQL and Postgres Module [shardingsphere]
linghengqian opened a new pull request, #29357:
URL: https://github.com/apache/shardingsphere/pull/29357
For #29052.
Changes proposed in this pull request:
- Provide relevant nativeTest and corresponding GraalVM Reachability Metadata for MySQL and Postgres Module.
- Provide corresponding GraalVM Reachability Metadata for `com.mysql:mysql-connector-j:8.0.31` temporarily .
- Ideally we should use `testcontainers-java` instead of `java.lang.Process` to create Docker containers. But since the shaded package in `testcontainers-java` requires additional GraalVM Reachability Metadata, I tend to handle this issue in a separate PR. Reference https://github.com/oracle/graalvm-reachability-metadata/issues/377.
- This PR has not yet completed the handling of limiting unit test execution.
- Fix postgres wrong testcontainers jdbcUrl prefix.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Provide relevant nativeTest and corresponding GraalVM Reachability Metadata for MySQL and Postgres Module [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #29357:
URL: https://github.com/apache/shardingsphere/pull/29357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org