You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2015/01/15 19:39:45 UTC
Review Request 29939: Allow a set of property names to ignore to be
passed into the predicate compiler
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29939/
-----------------------------------------------------------
Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-9153
https://issues.apache.org/jira/browse/AMBARI-9153
Repository: ambari
Description
-------
The introduction of request directives to the query string requires that the request can tell the predicate compiler to ignore these directives.
This patch introduces an overloaded compile method of PredicateCompiler which allows the caller to pass in a set of property names to ignore.
These ignored properties, will be discared by the lexer and will not be parsed into a predicate.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/PredicateCompiler.java 7738d2c
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java 3940c34
ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java a587480
Diff: https://reviews.apache.org/r/29939/diff/
Testing
-------
Added new unit test.
All unit tests pass.
Thanks,
John Speidel
Re: Review Request 29939: Allow a set of property names to ignore to
be passed into the predicate compiler
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29939/#review68293
-----------------------------------------------------------
Ship it!
Looks good.
- Robert Nettleton
On Jan. 15, 2015, 6:39 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29939/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 6:39 p.m.)
>
>
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-9153
> https://issues.apache.org/jira/browse/AMBARI-9153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The introduction of request directives to the query string requires that the request can tell the predicate compiler to ignore these directives.
> This patch introduces an overloaded compile method of PredicateCompiler which allows the caller to pass in a set of property names to ignore.
> These ignored properties, will be discared by the lexer and will not be parsed into a predicate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/PredicateCompiler.java 7738d2c
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java 3940c34
> ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java a587480
>
> Diff: https://reviews.apache.org/r/29939/diff/
>
>
> Testing
> -------
>
> Added new unit test.
> All unit tests pass.
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 29939: Allow a set of property names to ignore to
be passed into the predicate compiler
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29939/#review68297
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Jan. 15, 2015, 6:39 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29939/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 6:39 p.m.)
>
>
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-9153
> https://issues.apache.org/jira/browse/AMBARI-9153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The introduction of request directives to the query string requires that the request can tell the predicate compiler to ignore these directives.
> This patch introduces an overloaded compile method of PredicateCompiler which allows the caller to pass in a set of property names to ignore.
> These ignored properties, will be discared by the lexer and will not be parsed into a predicate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/PredicateCompiler.java 7738d2c
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java 3940c34
> ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java a587480
>
> Diff: https://reviews.apache.org/r/29939/diff/
>
>
> Testing
> -------
>
> Added new unit test.
> All unit tests pass.
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 29939: Allow a set of property names to ignore to
be passed into the predicate compiler
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29939/#review68288
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Jan. 15, 2015, 1:39 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29939/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 1:39 p.m.)
>
>
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-9153
> https://issues.apache.org/jira/browse/AMBARI-9153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The introduction of request directives to the query string requires that the request can tell the predicate compiler to ignore these directives.
> This patch introduces an overloaded compile method of PredicateCompiler which allows the caller to pass in a set of property names to ignore.
> These ignored properties, will be discared by the lexer and will not be parsed into a predicate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/PredicateCompiler.java 7738d2c
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java 3940c34
> ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java a587480
>
> Diff: https://reviews.apache.org/r/29939/diff/
>
>
> Testing
> -------
>
> Added new unit test.
> All unit tests pass.
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 29939: Allow a set of property names to ignore to
be passed into the predicate compiler
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29939/
-----------------------------------------------------------
(Updated Jan. 15, 2015, 7:24 p.m.)
Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-9153
https://issues.apache.org/jira/browse/AMBARI-9153
Repository: ambari
Description
-------
The introduction of request directives to the query string requires that the request can tell the predicate compiler to ignore these directives.
This patch introduces an overloaded compile method of PredicateCompiler which allows the caller to pass in a set of property names to ignore.
These ignored properties, will be discared by the lexer and will not be parsed into a predicate.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/PredicateCompiler.java 7738d2c
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java 3940c34
ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java a587480
Diff: https://reviews.apache.org/r/29939/diff/
Testing (updated)
-------
Added new unit test.
All unit tests pass.
Results :
Tests run: 2546, Failures: 0, Errors: 0, Skipped: 15
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:08.436s
[INFO] Finished at: Thu Jan 15 14:20:27 EST 2015
[INFO] Final Memory: 34M/408M
[INFO] ------------------------------------------------------------------------
Thanks,
John Speidel