Re: [VOTE] upgrade the DataMapper 1.2.1/ DataAccess 1.6.1 to General Availibilty

[Ron Grabowski <ro...@yahoo.com>]

TimeSpanTypeHandler.cs isn't implemented yet:

public override object GetValueByName(ResultProperty mapping,
IDataReader dataReader)
{
//return GetValueByIndex(dataReader.GetOrdinal(columnName),
dataReader);
return "ToDo";
}

This might be an ok implementation assuming GetDateTime doesn't return
null:

 return dataReader.GetDateTime(index).TimeOfDay;

I wonder if there's a more direct way of getting a TimeSpan without
having to first convert it to a DateTime:

 public override object ValueOf(Type type, string s)
 {
  return Convert.ToDateTime(s).TimeOfDay;
 }

 public override object GetDataBaseValue(object outputValue, Type
parameterType )
 {
  return Convert.ToDateTime(outputValue).TimeOfDay;
 }

That should probably be fixed before the release. Do we get to start
over again :-)

--- Ted Husted <te...@gmail.com> wrote:

> I ran it through the guantlet again this morning, all tests are
> green,
> and no one bugged me about a conflict, so +1.
> 
> -T.
> 
> On 6/30/05, Gilles Bayon <ib...@gmail.com> wrote:
> > It's has been fixed.
>