You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CrazyHZM (GitHub)" <gi...@apache.org> on 2019/01/15 03:55:30 UTC

[GitHub] [incubator-dubbo] CrazyHZM opened pull request #3230: call the util method

## What is the purpose of the change
Code optimization, call the util method


## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3230 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] LiZhenNet commented on issue #3230: call the util method

Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
CollectionUtils 里面关于Map 的判断是不是单独抽离到MapUtils 里 会更好些

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3230 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on issue #3230: call the util method

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
good job.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3230 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] khanimteyaz commented on issue #3230: call the util method

Posted by "khanimteyaz (GitHub)" <gi...@apache.org>.
Looks good to me.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3230 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] phqct commented on issue #3230: call the util method

Posted by "phqct (GitHub)" <gi...@apache.org>.
你们能别给我发邮件吗 怎么屏蔽你们 天天发邮件


________________________________
penghao0426@outlook.com

From: Imteyaz Ahmed Khan<ma...@github.com>
Date: 2019-01-15 15:52
To: apache/incubator-dubbo<ma...@noreply.github.com>
CC: Subscribed<ma...@noreply.github.com>
Subject: Re: [apache/incubator-dubbo] call the util method (#3230)

@khanimteyaz approved this pull request.

―
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-dubbo/pull/3230#pullrequestreview-192516537>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AqChVMdqhOzN28W7cYVv7TrBuPd-gEuCks5vDYixgaJpZM4aAMfe>.


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3230 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3230: call the util method

Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
> CollectionUtils 里面关于Map 的判断是不是单独抽离到MapUtils 里 会更好些

这个utils里面还有其他关于map的操作

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3230 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3230: call the util method

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=h1) Report
> Merging [#3230](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f76ae2165018ca78cbb9286fe9bd4869bc2dbeb6?src=pr&el=desc) will **increase** coverage by `0.23%`.
> The diff coverage is `36.07%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3230      +/-   ##
============================================
+ Coverage     63.69%   63.92%   +0.23%     
  Complexity       75       75              
============================================
  Files           652      652              
  Lines         28200    28200              
  Branches       4781     4779       -2     
============================================
+ Hits          17962    18028      +66     
- Misses         7979     7980       +1     
+ Partials       2259     2192      -67
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/dubbo/container/log4j/Log4jContainer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tY29udGFpbmVyL2R1YmJvLWNvbnRhaW5lci1sb2c0ai9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29udGFpbmVyL2xvZzRqL0xvZzRqQ29udGFpbmVyLmphdmE=) | `12.19% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/dubbo/rpc/protocol/AbstractInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9BYnN0cmFjdEludm9rZXIuamF2YQ==) | `66.12% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ng/telnet/support/command/StatusTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90ZWxuZXQvc3VwcG9ydC9jb21tYW5kL1N0YXR1c1RlbG5ldEhhbmRsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ing/transport/netty4/logging/MessageFormatter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L2xvZ2dpbmcvTWVzc2FnZUZvcm1hdHRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1pbmp2bS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2luanZtL0luanZtUHJvdG9jb2wuamF2YQ==) | `78.37% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1JlZmVyZW5jZUFubm90YXRpb25CZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `76.38% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `66.66% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/dubbo/filter/TraceFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL2ZpbHRlci9UcmFjZUZpbHRlci5qYXZh) | `12.5% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ting/transport/netty4/logging/FormattingTuple.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L2xvZ2dpbmcvRm9ybWF0dGluZ1R1cGxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/dubbo/rpc/protocol/http/HttpProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvaHR0cC9IdHRwUHJvdG9jb2wuamF2YQ==) | `71.25% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [67 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=footer). Last update [f76ae21...799ff69](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3230 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3230: call the util method

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=h1) Report
> Merging [#3230](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/0e0fbd5db890a6f976d7e45e6af3516efc2aa076?src=pr&el=desc) will **increase** coverage by `0.27%`.
> The diff coverage is `36.07%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3230      +/-   ##
============================================
+ Coverage     63.64%   63.92%   +0.27%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28218    28218              
  Branches       4784     4782       -2     
============================================
+ Hits          17960    18039      +79     
+ Misses         7996     7988       -8     
+ Partials       2262     2191      -71
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/dubbo/container/log4j/Log4jContainer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tY29udGFpbmVyL2R1YmJvLWNvbnRhaW5lci1sb2c0ai9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29udGFpbmVyL2xvZzRqL0xvZzRqQ29udGFpbmVyLmphdmE=) | `12.19% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/dubbo/rpc/protocol/AbstractInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9BYnN0cmFjdEludm9rZXIuamF2YQ==) | `66.12% <0%> (+3.22%)` | `0 <0> (ø)` | :arrow_down: |
| [...ng/telnet/support/command/StatusTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90ZWxuZXQvc3VwcG9ydC9jb21tYW5kL1N0YXR1c1RlbG5ldEhhbmRsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ing/transport/netty4/logging/MessageFormatter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L2xvZ2dpbmcvTWVzc2FnZUZvcm1hdHRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1pbmp2bS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2luanZtL0luanZtUHJvdG9jb2wuamF2YQ==) | `78.37% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1JlZmVyZW5jZUFubm90YXRpb25CZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `76.38% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `66.66% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/dubbo/filter/TraceFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL2ZpbHRlci9UcmFjZUZpbHRlci5qYXZh) | `12.5% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ting/transport/netty4/logging/FormattingTuple.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L2xvZ2dpbmcvRm9ybWF0dGluZ1R1cGxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/dubbo/rpc/protocol/http/HttpProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvaHR0cC9IdHRwUHJvdG9jb2wuamF2YQ==) | `71.25% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [66 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3230/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=footer). Last update [0e0fbd5...2723f2d](https://codecov.io/gh/apache/incubator-dubbo/pull/3230?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3230 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3230: call the util method

Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
After the recommendation, the code review will pay attention to the existing util method.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3230 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 closed pull request #3230: call the util method

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3230 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org