[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

["korlov42 (via GitHub)" <gi...@apache.org>]

korlov42 commented on code in PR #2243:
URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239486944


##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommandParams.java:
##########
@@ -41,6 +47,20 @@ public String schemaName() {
         return schema;
     }
 
+    /**
+     * Returns table name.
+     */
+    public String tableName() {
+        return tableName;
+    }
+
+    /**
+     * Returns {@code true} if index is unique, {@code false} otherwise.
+     */
+    public boolean isUnique() {

Review Comment:
   we either need to add prefix to every getter or don't use it at all within *Params classes



##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java:
##########
@@ -137,66 +137,61 @@ public CatalogServiceImpl(UpdateLog updateLog, HybridClock clock, long delayDura
         this.delayDurationMs = delayDurationMs;
     }
 
-    /** {@inheritDoc} */

Review Comment:
   what is wrong with this javadoc (and rest of the similar)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org