[jira] [Work logged] (TS-4578) Skip HostDB lookup for all address literals

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-4578?focusedWorklogId=30159&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30159 ]

ASF GitHub Bot logged work on TS-4578:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Oct/16 04:41
            Start Date: 05/Oct/16 04:41
    Worklog Time Spent: 10m 
      Work Description: GitHub user davidbz opened a pull request:

    https://github.com/apache/trafficserver/pull/1079

    TS-4578: Skip HostDB lookup for all address literals

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davidbz/trafficserver TS-4578

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1079
    
----
commit 47610146a60a698014b7c51dce149756ccf968f4
Author: David Ben Zakai <da...@gmail.com>
Date:   2016-10-05T04:39:52Z

    TS-4578: Skip HostDB lookup for all address literals

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 30159)
            Time Spent: 10m
    Remaining Estimate: 0h

> Skip HostDB lookup for all address literals
> -------------------------------------------
>
>                 Key: TS-4578
>                 URL: https://issues.apache.org/jira/browse/TS-4578
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core, DNS
>            Reporter: James Peach
>            Assignee: David Ben Zakai
>              Labels: newbie
>             Fix For: sometime
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In {{HttpSM.cc}}:
> {code}
>     if ((strncmp(t_state.dns_info.lookup_name, "127.0.0.1", 9) == 0 || strncmp(t_state.dns_info.lookup_name, "::1", 3) == 0) &&
>         ats_ip_pton(t_state.dns_info.lookup_name, t_state.host_db_info.ip()) == 0) {
>       // If it's 127.0.0.1 or ::1 don't bother with hostdb
>       DebugSM("dns", "[HttpTransact::HandleRequest] Skipping DNS lookup for %s because it's loopback",
>               t_state.dns_info.lookup_name);
>       t_state.dns_info.lookup_success = true;
>       call_transact_and_set_next_state(NULL);
>       break;
> {code}
> There's no reason to restrict address literals to loopback. It seems like we should be able to do this for all address literals.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)