You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/09/24 07:28:01 UTC

[jira] Created: (MPIDEA-10) Include all dependencies in multiproject build as modules: allow specifying generated source directories.

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPIDEA-10

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPIDEA-10
    Summary: Include all dependencies in multiproject build as modules: allow specifying generated source directories.
       Type: Improvement

     Status: Open
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-idea-plugin

   Assignee: Brett Porter
   Reporter: David Jencks

    Created: Fri, 24 Sep 2004 1:26 AM
    Updated: Fri, 24 Sep 2004 1:26 AM

Description:
The enclosed patch includes two enhancements to the idea plugin.

1. In idea:multiproject, instead of basing decisions about whether a dependency is a module or a library dependency on whether the groupId matches the current groupId, the decision is based on whether the dependency is in fact built in the current build, i.e. whether it is in the idea.multiproject.includes set.  This makes the plugin usable for projects spanning several groupIds and avoids problems in cases when you do not wish to build some dependencies even though they have the same groupId.

2. In each module, generated source directories inside target (such as from xmlbeans or xdoclet) can be added by including e.g. maven.idea.generated.source=xmlbeans

It is entirely possible that the implementation of (1) could be improved, since it does some fancy jelly scripting to get the list of projects in the multiproject build accessible to each project.

For (2), I've not followed the eclipse model of allowing an arbitrary path to additional source directories since I think the only appropriate place for them is in the target directory.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPIDEA-10) Include all dependencies in multiproject build as modules: allow specifying generated source directories.

Posted by ji...@codehaus.org.
The following issue has been updated:

    Updater: David Jencks (mailto:david@coredevelopers.net)
       Date: Fri, 24 Sep 2004 1:27 AM
    Changes:
             Attachment changed to diff.txt
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPIDEA-10?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPIDEA-10

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPIDEA-10
    Summary: Include all dependencies in multiproject build as modules: allow specifying generated source directories.
       Type: Improvement

     Status: Open
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-idea-plugin

   Assignee: Brett Porter
   Reporter: David Jencks

    Created: Fri, 24 Sep 2004 1:26 AM
    Updated: Fri, 24 Sep 2004 1:27 AM

Description:
The enclosed patch includes two enhancements to the idea plugin.

1. In idea:multiproject, instead of basing decisions about whether a dependency is a module or a library dependency on whether the groupId matches the current groupId, the decision is based on whether the dependency is in fact built in the current build, i.e. whether it is in the idea.multiproject.includes set.  This makes the plugin usable for projects spanning several groupIds and avoids problems in cases when you do not wish to build some dependencies even though they have the same groupId.

2. In each module, generated source directories inside target (such as from xmlbeans or xdoclet) can be added by including e.g. maven.idea.generated.source=xmlbeans

It is entirely possible that the implementation of (1) could be improved, since it does some fancy jelly scripting to get the list of projects in the multiproject build accessible to each project.

For (2), I've not followed the eclipse model of allowing an arbitrary path to additional source directories since I think the only appropriate place for them is in the target directory.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MPIDEA-10) Include all dependencies in multiproject build as modules: allow specifying generated source directories.

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPIDEA-10?page=all ]
     
Brett Porter closed MPIDEA-10:
------------------------------

    Fix Version: 1.6
     Resolution: Fixed

applied (finally!). Thanks.
I'm changing the JDK handling to use maven.compile.source instead of a custom property, however.

> Include all dependencies in multiproject build as modules: allow specifying generated source directories.
> ---------------------------------------------------------------------------------------------------------
>
>          Key: MPIDEA-10
>          URL: http://jira.codehaus.org/browse/MPIDEA-10
>      Project: maven-idea-plugin
>         Type: Improvement
>     Reporter: David Jencks
>      Fix For: 1.6
>  Attachments: diff.txt, diff2.txt, xdocs.diff
>
>
> The enclosed patch includes two enhancements to the idea plugin.
> 1. In idea:multiproject, instead of basing decisions about whether a dependency is a module or a library dependency on whether the groupId matches the current groupId, the decision is based on whether the dependency is in fact built in the current build, i.e. whether it is in the idea.multiproject.includes set.  This makes the plugin usable for projects spanning several groupIds and avoids problems in cases when you do not wish to build some dependencies even though they have the same groupId.
> 2. In each module, generated source directories inside target (such as from xmlbeans or xdoclet) can be added by including e.g. maven.idea.generated.source=xmlbeans
> It is entirely possible that the implementation of (1) could be improved, since it does some fancy jelly scripting to get the list of projects in the multiproject build accessible to each project.
> For (2), I've not followed the eclipse model of allowing an arbitrary path to additional source directories since I think the only appropriate place for them is in the target directory.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPIDEA-10) Include all dependencies in multiproject build as modules: allow specifying generated source directories.

Posted by ji...@codehaus.org.
The following issue has been updated:

    Updater: David Jencks (mailto:david@coredevelopers.net)
       Date: Sat, 27 Nov 2004 1:05 PM
    Comment:
add row to properties table explaining maven.idea.generated.source property.
    Changes:
             Attachment changed to xdocs.diff
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPIDEA-10?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPIDEA-10

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPIDEA-10
    Summary: Include all dependencies in multiproject build as modules: allow specifying generated source directories.
       Type: Improvement

     Status: Open
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-idea-plugin

   Assignee: Brett Porter
   Reporter: David Jencks

    Created: Fri, 24 Sep 2004 1:26 AM
    Updated: Sat, 27 Nov 2004 1:05 PM

Description:
The enclosed patch includes two enhancements to the idea plugin.

1. In idea:multiproject, instead of basing decisions about whether a dependency is a module or a library dependency on whether the groupId matches the current groupId, the decision is based on whether the dependency is in fact built in the current build, i.e. whether it is in the idea.multiproject.includes set.  This makes the plugin usable for projects spanning several groupIds and avoids problems in cases when you do not wish to build some dependencies even though they have the same groupId.

2. In each module, generated source directories inside target (such as from xmlbeans or xdoclet) can be added by including e.g. maven.idea.generated.source=xmlbeans

It is entirely possible that the implementation of (1) could be improved, since it does some fancy jelly scripting to get the list of projects in the multiproject build accessible to each project.

For (2), I've not followed the eclipse model of allowing an arbitrary path to additional source directories since I think the only appropriate place for them is in the target directory.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPIDEA-10) Include all dependencies in multiproject build as modules: allow specifying generated source directories.

Posted by ji...@codehaus.org.
The following issue has been updated:

    Updater: David Jencks (mailto:david@coredevelopers.net)
       Date: Sat, 27 Nov 2004 11:58 AM
    Comment:
Enhanced version of previous patch.  Most of the geronimo team has been using versions of this patch for several months, and I'm getting tired of distributing it by hand.
    Changes:
             Attachment changed to diff2.txt
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPIDEA-10?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPIDEA-10

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPIDEA-10
    Summary: Include all dependencies in multiproject build as modules: allow specifying generated source directories.
       Type: Improvement

     Status: Open
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-idea-plugin

   Assignee: Brett Porter
   Reporter: David Jencks

    Created: Fri, 24 Sep 2004 1:26 AM
    Updated: Sat, 27 Nov 2004 11:58 AM

Description:
The enclosed patch includes two enhancements to the idea plugin.

1. In idea:multiproject, instead of basing decisions about whether a dependency is a module or a library dependency on whether the groupId matches the current groupId, the decision is based on whether the dependency is in fact built in the current build, i.e. whether it is in the idea.multiproject.includes set.  This makes the plugin usable for projects spanning several groupIds and avoids problems in cases when you do not wish to build some dependencies even though they have the same groupId.

2. In each module, generated source directories inside target (such as from xmlbeans or xdoclet) can be added by including e.g. maven.idea.generated.source=xmlbeans

It is entirely possible that the implementation of (1) could be improved, since it does some fancy jelly scripting to get the list of projects in the multiproject build accessible to each project.

For (2), I've not followed the eclipse model of allowing an arbitrary path to additional source directories since I think the only appropriate place for them is in the target directory.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org