You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/01/21 06:51:12 UTC
[GitHub] [arrow] kou opened a new pull request, #33812: GH-33796: [C++] Fix wrong arrow-testing.pc config with system GoogleTest
kou opened a new pull request, #33812:
URL: https://github.com/apache/arrow/pull/33812
### Rationale for this change
Empty `-I` in `Cflags:` generates an invalid build command line.
### What changes are included in this PR?
Add `Requires: gtest` if `gtest.pc` exists.
Add `Cflags: -I...` and `Libs: /.../libgtest.a` if `gtest.pc` doesn't exist.
Bundled GoogleTest isn't supported yet.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #33812: GH-33796: [C++] Fix wrong arrow-testing.pc config with system GoogleTest
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #33812:
URL: https://github.com/apache/arrow/pull/33812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #33812: GH-33796: [C++] Fix wrong arrow-testing.pc config with system GoogleTest
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #33812:
URL: https://github.com/apache/arrow/pull/33812#issuecomment-1402899143
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #33812: GH-33796: [C++] Fix wrong arrow-testing.pc config with system GoogleTest
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #33812:
URL: https://github.com/apache/arrow/pull/33812#issuecomment-1403060047
Benchmark runs are scheduled for baseline = f3637aca7750f43f7e1766e4495254f98adbe40b and contender = 716b3b2c9a2aa1c2dc5704ab74fa3ba6dddd1177. 716b3b2c9a2aa1c2dc5704ab74fa3ba6dddd1177 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/90ecfcaa869b4e79a7a982de502b71e5...f35aafacc489426ebc076240b4b8875c/)
[Failed :arrow_down:0.54% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d14694623fc2495bbc783b26cf08a478...ac2eccde013244549acc78716d2431b9/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7043ec9dee3449cc8c5a6e698f4290bd...a71653a21390457ba52b130bbf25c82c/)
[Finished :arrow_down:0.47% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/302a2b81c09e4bf4a607a758349930f6...1ce41cbb6f714474be661fcb05d4ddf9/)
Buildkite builds:
[Finished] [`716b3b2c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2259)
[Failed] [`716b3b2c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2284)
[Failed] [`716b3b2c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2254)
[Finished] [`716b3b2c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2277)
[Finished] [`f3637aca` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2258)
[Failed] [`f3637aca` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2283)
[Failed] [`f3637aca` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2253)
[Finished] [`f3637aca` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2276)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org