[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2117: feat: basic support Apache APISIX 2.9

[GitBox <gi...@apache.org>]

bzp2010 commented on a change in pull request #2117:
URL: https://github.com/apache/apisix-dashboard/pull/2117#discussion_r701746446



##########
File path: api/internal/core/entity/entity.go
##########
@@ -97,10 +97,11 @@ type Route struct {
 }
 
 // --- structures for upstream start  ---
+type TimeoutValue float32

Review comment:
       There are two "number" definitions in jsonschema, one is an `integer`, the other is `number`, where `number` runs to store float values. Such as 5.5
   
   Therefore, a float value is used here to store.
   
   In addition, only map[string]interface{} was used to store the value before, and there was ambiguity in the data type.  Crash may occur during runtime.  This is also the reason for this modification.（add a Timeout struct）




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org