[GitHub] wu-sheng commented on a change in pull request #1053: fix trace no data

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #1053: fix trace no data
URL: https://github.com/apache/incubator-skywalking/pull/1053#discussion_r179981523
 
 

 ##########
 File path: apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/SegmentDurationEsUIDAO.java
 ##########
 @@ -57,8 +58,9 @@ public TraceBrief loadTop(long startSecondTimeBucket, long endSecondTimeBucket,
         List<QueryBuilder> mustQueryList = boolQueryBuilder.must();
 
         if (startSecondTimeBucket != 0 && endSecondTimeBucket != 0) {
-            //TODO second
-            mustQueryList.add(QueryBuilders.rangeQuery(SegmentDurationTable.COLUMN_TIME_BUCKET).gte(startSecondTimeBucket).lte(endSecondTimeBucket));
+            mustQueryList.add(QueryBuilders.rangeQuery(SegmentDurationTable.COLUMN_TIME_BUCKET)
+                    .gte(TimeBucketUtils.INSTANCE.secondToMinute(startSecondTimeBucket))
 
 Review comment:
   This time format should already done in `TraceQuery#queryBasicTraces#L71`. And the query works in our demo env and product env.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services