You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@polaris.apache.org by "adam-christian-software (via GitHub)" <gi...@apache.org> on 2025/12/23 15:11:48 UTC

[PR] DO NOT MERGE: Polaris Core SPI Idea [polaris]

adam-christian-software opened a new pull request, #3320:
URL: https://github.com/apache/polaris/pull/3320

   Based on discussions in the first community sprint, this is an idea of splitting Polaris into Polaris-Core-SPI & Polaris-Core-Impl.
   
   ## Checklist
   - [ ] 🛡️ Don't disclose security issues! (contact security@apache.org)
   - [ ] 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
   - [ ] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
   - [ ] 💡 Added comments for complex logic
   - [ ] 🧾 Updated `CHANGELOG.md` (if needed)
   - [ ] 📚 Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DO NOT MERGE: Polaris Core SPI Idea [polaris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #3320:
URL: https://github.com/apache/polaris/pull/3320#issuecomment-3815005431

   This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DO NOT MERGE: Polaris Core SPI Idea [polaris]

Posted by "adam-christian-software (via GitHub)" <gi...@apache.org>.

adam-christian-software commented on code in PR #3320:
URL: https://github.com/apache/polaris/pull/3320#discussion_r2651201869


##########
polaris-core-spi/build.gradle.kts:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+plugins { id("polaris-client") }
+
+dependencies {
+  compileOnly(libs.jakarta.annotation.api)
+  compileOnly(libs.guava)
+
+  compileOnly(platform(libs.jackson.bom))
+  compileOnly("com.fasterxml.jackson.core:jackson-annotations")
+  compileOnly("com.fasterxml.jackson.core:jackson-databind")
+  compileOnly("com.fasterxml.jackson.dataformat:jackson-dataformat-smile")
+  compileOnly("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml")
+
+  compileOnly(project(":polaris-immutables"))
+  annotationProcessor(project(":polaris-immutables", configuration = "processor"))
+
+  compileOnly(project(":polaris-api-management-model"))
+
+  compileOnly(platform(libs.iceberg.bom))
+  compileOnly("org.apache.iceberg:iceberg-api")
+  compileOnly("org.apache.iceberg:iceberg-core")

Review Comment:
   So, there imports of at least:
   org.apache.iceberg.rest.auth.OAuth2Properties
   org.apache.iceberg.rest.auth.OAuth2Util
   org.apache.iceberg.rest.auth.AuthProperties
   org.apache.iceberg.CatalogProperties
   org.apache.iceberg.TableMetadata
   org.apache.iceberg.view.ViewMetadata
   org.apache.iceberg.rest.RESTUtil
   org.apache.iceberg.rest.RESTSerializers
   
   I agree that it does not seem like this would be what we would want longer-term.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DO NOT MERGE: Polaris Core SPI Idea [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.

dimas-b commented on code in PR #3320:
URL: https://github.com/apache/polaris/pull/3320#discussion_r2643532438


##########
polaris-core-spi/build.gradle.kts:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+plugins { id("polaris-client") }
+
+dependencies {
+  compileOnly(libs.jakarta.annotation.api)
+  compileOnly(libs.guava)
+
+  compileOnly(platform(libs.jackson.bom))
+  compileOnly("com.fasterxml.jackson.core:jackson-annotations")
+  compileOnly("com.fasterxml.jackson.core:jackson-databind")
+  compileOnly("com.fasterxml.jackson.dataformat:jackson-dataformat-smile")
+  compileOnly("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml")
+
+  compileOnly(project(":polaris-immutables"))
+  annotationProcessor(project(":polaris-immutables", configuration = "processor"))
+
+  compileOnly(project(":polaris-api-management-model"))
+
+  compileOnly(platform(libs.iceberg.bom))
+  compileOnly("org.apache.iceberg:iceberg-api")
+  compileOnly("org.apache.iceberg:iceberg-core")

Review Comment:
   Why is `iceberg-core` a dependency of Polaris SPI? 🤔 



##########
polaris-core-spi/src/main/java/org/apache/polaris/core/catalog/PolarisCatalogHelpers.java:
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.core.catalog;
+
+import com.google.common.collect.ImmutableList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+import org.apache.iceberg.catalog.Namespace;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.apache.polaris.core.entity.PolarisEntity;
+
+/**
+ * Holds helper methods translating between persistence-layer structs and Iceberg objects shared by

Review Comment:
   Just from the javadoc it does not look like this class belongs in an SPI 🤔 It is not something to be implemented by plugins 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DO NOT MERGE: Polaris Core SPI Idea [polaris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed pull request #3320: DO NOT MERGE: Polaris Core SPI Idea
URL: https://github.com/apache/polaris/pull/3320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DO NOT MERGE: Polaris Core SPI Idea [polaris]

Posted by "adam-christian-software (via GitHub)" <gi...@apache.org>.

adam-christian-software commented on code in PR #3320:
URL: https://github.com/apache/polaris/pull/3320#discussion_r2651204214


##########
polaris-core-spi/src/main/java/org/apache/polaris/core/catalog/PolarisCatalogHelpers.java:
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.core.catalog;
+
+import com.google.common.collect.ImmutableList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+import org.apache.iceberg.catalog.Namespace;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.apache.polaris.core.entity.PolarisEntity;
+
+/**
+ * Holds helper methods translating between persistence-layer structs and Iceberg objects shared by

Review Comment:
   It's used by NamespaceEntity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org