You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/12/13 07:29:42 UTC

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a diff in pull request #1418: nimble/fem: Add runtime default antenna selection to SKY66112

andrzej-kaczmarek commented on code in PR #1418:
URL: https://github.com/apache/mynewt-nimble/pull/1418#discussion_r1046745228


##########
nimble/drivers/fem/sky66112/src/sky66112.c:
##########
@@ -145,6 +149,18 @@ sky66112_tx_bypass(uint8_t enabled)
     }
 }
 
+#if !MYNEWT_VAL_CHOICE(SKY66112_ANTENNA_PORT, runtime)
+uint8_t
+sky66112_default_antenna(void)
+{
+    if (MYNEWT_VAL_CHOICE(SKY66112_ANTENNA_PORT, ANT1)) {

Review Comment:
   I think it should be ant2 only if selected, ant1 otherwise



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org