[GitHub] [doris] wsjz commented on a diff in pull request #15418: [feature-wip](multi-catalog) support Iceberg time travel in external table

[GitBox <gi...@apache.org>]

wsjz commented on code in PR #15418:
URL: https://github.com/apache/doris/pull/15418#discussion_r1058814877


##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -5095,9 +5098,31 @@ base_table_ref_list ::=
   ;
 
 base_table_ref ::=
-    table_name:name opt_partition_names:partitionNames opt_tablet_list:tabletIds opt_table_alias:alias opt_table_sample:tableSample opt_common_hints:commonHints
+    table_name:name opt_snapshot_version:snapshotVersion opt_partition_names:partitionNames opt_tablet_list:tabletIds opt_table_alias:alias opt_table_sample:tableSample opt_common_hints:commonHints
     {:
-        RESULT = new TableRef(name, alias, partitionNames, tabletIds, tableSample, commonHints);
+        RESULT = new TableRef(name, alias, partitionNames, tabletIds, tableSample, commonHints, snapshotVersion);
+    :}
+    ;
+
+opt_snapshot_version ::=
+    /* empty */
+    {:
+        RESULT = null;
+    :}
+    | snapshot_version:snapshotVersion
+    {:
+        RESULT = snapshotVersion;
+    :}
+    ;
+
+snapshot_version ::=

Review Comment:
   it maybe not only external table support time travel in the future
   but indeed need change the name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org