You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by jb...@apache.org on 2006/02/28 01:07:27 UTC
svn commit: r381503 -
/incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/context/impl/AbstractAggregateContext.java
Author: jboynes
Date: Mon Feb 27 16:07:24 2006
New Revision: 381503
URL: http://svn.apache.org/viewcvs?rev=381503&view=rev
Log:
report missing implementation as a error rather than a NPE
Modified:
incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/context/impl/AbstractAggregateContext.java
Modified: incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/context/impl/AbstractAggregateContext.java
URL: http://svn.apache.org/viewcvs/incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/context/impl/AbstractAggregateContext.java?rev=381503&r1=381502&r2=381503&view=diff
==============================================================================
--- incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/context/impl/AbstractAggregateContext.java (original)
+++ incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/context/impl/AbstractAggregateContext.java Mon Feb 27 16:07:24 2006
@@ -53,6 +53,7 @@
import org.apache.tuscany.model.assembly.ExternalService;
import org.apache.tuscany.model.assembly.Module;
import org.apache.tuscany.model.assembly.Scope;
+import org.apache.tuscany.model.assembly.ComponentImplementation;
import org.apache.tuscany.model.assembly.impl.AssemblyFactoryImpl;
/**
@@ -288,8 +289,14 @@
Module newModule = (Module) model;
module = newModule;
for (Component component : newModule.getComponents()) {
- configuration = (RuntimeConfiguration<InstanceContext>) component.getComponentImplementation()
- .getRuntimeConfiguration();
+ ComponentImplementation componentImplementation = component.getComponentImplementation();
+ if (componentImplementation == null) {
+ ConfigurationException e = new ConfigurationException("Component implementation not set");
+ e.addContextName(component.getName());
+ e.addContextName(getName());
+ throw e;
+ }
+ configuration = (RuntimeConfiguration<InstanceContext>) componentImplementation .getRuntimeConfiguration();
if (configuration == null) {
ConfigurationException e = new ConfigurationException("Runtime configuration not set");
e.addContextName(component.getName());