You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by ykunda <gi...@git.apache.org> on 2017/08/01 12:26:55 UTC
[GitHub] zookeeper pull request #323: ZOOKEEPER-2861: Main-Class JAR manifest attribu...
GitHub user ykunda opened a pull request:
https://github.com/apache/zookeeper/pull/323
ZOOKEEPER-2861: Main-Class JAR manifest attribute is incorrect
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykunda/zookeeper master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #323
----
commit 27faf97e1defa8f9544e307dd7dc65730f43cb6e
Author: yaniv.kunda <ya...@kundas.net>
Date: 2017-08-01T12:24:51Z
ZOOKEEPER-2861: Main-Class JAR manifest attribute is incorrect
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #323: ZOOKEEPER-2861: Main-Class JAR manifest attribute is i...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/323
Thank you for your contribution, @ykunda.
Committed to master: 09742f2d050105689592ffb5f5240ebde6f79dee
branch-3.5: 2f9cba5694c6b89b93959acfe1c4c7b3c3e91b7d
branch-3.4: 955611e294151fee77b5b95829ebf117c65317ed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #323: ZOOKEEPER-2861: Main-Class JAR manifest attribu...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/323#discussion_r131256912
--- Diff: build.xml ---
@@ -578,7 +578,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<fileset dir="${java.src.dir}"/>
<fileset dir="${src_generated.dir}" excludes="**/.generated"/>
<manifest>
- <attribute name="Main-Class" value="org.apache.zookeeper.server.quorum.QuorumPeer" />
+ <attribute name="Main-Class" value="org.apache.zookeeper.server.quorum.QuorumPeerMain" />
--- End diff --
does this change also need to be made on https://github.com/apache/zookeeper/pull/323/files#diff-2cccd7bf48b7a9cc113ff564acd802a8R622 (line 622)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #323: ZOOKEEPER-2861: Main-Class JAR manifest attribu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/323
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---