You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "fabriziofortino (via GitHub)" <gi...@apache.org> on 2026/01/26 13:41:58 UTC
[PR] OAK-12071: fix property removal for externally modifiable indexes [jackrabbit-oak]
fabriziofortino opened a new pull request, #2700:
URL: https://github.com/apache/jackrabbit-oak/pull/2700
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12071: fix property removal for externally modifiable indexes [jackrabbit-oak]
Posted by "nit0906 (via GitHub)" <gi...@apache.org>.
nit0906 commented on PR #2700:
URL: https://github.com/apache/jackrabbit-oak/pull/2700#issuecomment-3802861824
> ElasticIndexQueryCommonTest>IndexQueryCommonTest.testMultiValuedPropUpdate
There's this test that fails on the PR. It has a remove property action - so could be possibly impacted by the change in the PR.
The failing test itself however could be improved a bit imo. The last assertion
> assertEventually(() -> assertQuery("/jcr:root//*[jcr:contains(@" + mulValuedProp + ", 'foo')]", "xpath", new ArrayList<>()));
should rather be
assertEventually(() -> assertQuery("/jcr:root//*[jcr:contains(@" + mulValuedProp + ", 'bar')]", "xpath", new ArrayList<>()));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12071: fix property removal for externally modifiable indexes [jackrabbit-oak]
Posted by "fabriziofortino (via GitHub)" <gi...@apache.org>.
fabriziofortino merged PR #2700:
URL: https://github.com/apache/jackrabbit-oak/pull/2700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12071: fix property removal for externally modifiable indexes [jackrabbit-oak]
Posted by "fabriziofortino (via GitHub)" <gi...@apache.org>.
fabriziofortino commented on PR #2700:
URL: https://github.com/apache/jackrabbit-oak/pull/2700#issuecomment-3805661393
@nit0906 can you review again? There was an issue with the logic but the test was passing locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org