You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/02/02 16:01:39 UTC

[GitHub] [cordova-docs] NiklasMerz opened a new pull request #1152: (ios): Document WKUrlSchemeTask

NiklasMerz opened a new pull request #1152:
URL: https://github.com/apache/cordova-docs/pull/1152


   This mentions just the method we added in 6.2.0 to hook into the WKWebView loading for plugin developers. Plugin developers might find it and come up with intersting solutions.
   
   Do we want to document this more? Do we want examples? Is it worth mentioning at all?
   
   Closes #1149 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] timbru31 commented on a change in pull request #1152: (ios): Document WKUrlSchemeTask

Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #1152:
URL: https://github.com/apache/cordova-docs/pull/1152#discussion_r569467218



##########
File path: www/docs/en/dev/guide/platforms/ios/plugin.md
##########
@@ -225,6 +225,10 @@ terminate and `handleOpenURL` events. See the
 [CDVPlugin.h][CDVPlugin.h] and [CDVPlugin.m][CDVPlugin.m]
 classes for guidance.
 
+### WKURLSchemeTask Hook
+
+The [WKURLSchemeTask](https://developer.apple.com/documentation/webkit/wkurlschemetask) is an interface Cordovas main WKWebView uses to load files from your apps bundle. You can create your own custom schemes or custom loading code for the webview by implementing the `- (BOOL) overrideSchemeTask: (id <WKURLSchemeTask>)urlSchemeTask` method in a plugin.

Review comment:
       ```suggestion
   The [WKURLSchemeTask](https://developer.apple.com/documentation/webkit/wkurlschemetask) is an interface Cordova's main WKWebView uses to load files from your app's bundle. You can create your own custom schemes or custom loading code for the webview by implementing the `- (BOOL) overrideSchemeTask: (id <WKURLSchemeTask>)urlSchemeTask` method in a plugin.
   ```
   
   Additional native speaker confirmation appreciated 😇 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] purplecabbage merged pull request #1152: (ios): Document WKUrlSchemeTask

Posted by GitBox <gi...@apache.org>.
purplecabbage merged pull request #1152:
URL: https://github.com/apache/cordova-docs/pull/1152


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] breautek commented on pull request #1152: (ios): Document WKUrlSchemeTask

Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1152:
URL: https://github.com/apache/cordova-docs/pull/1152#issuecomment-771917833


   > Do we want examples?
   
   I think a small code snippet to serve as an example would be beneficial.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] breautek commented on pull request #1152: (ios): Document WKUrlSchemeTask

Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1152:
URL: https://github.com/apache/cordova-docs/pull/1152#issuecomment-771917833


   > Do we want examples?
   
   I think a small code snippet to serve as an example would be beneficial.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org