You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/06/16 10:16:12 UTC

[GitHub] [iotdb] HTHou commented on a diff in pull request #6314: Change the meaning of `Flush` on cluster mode

HTHou commented on code in PR #6314:
URL: https://github.com/apache/iotdb/pull/6314#discussion_r898928750


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/config/FlushTask.java:
##########
@@ -54,10 +54,10 @@ public ListenableFuture<ConfigTaskResult> execute(IConfigTaskExecutor configTask
       tFlushReq.setIsSeq(flushStatement.isSeq().toString());
     }
     IoTDBConfig config = IoTDBDescriptor.getInstance().getConfig();
-    if (flushStatement.isLocal()) {
-      tFlushReq.setDataNodeId(config.getDataNodeId());
-    } else {
+    if (flushStatement.isCluster()) {
       tFlushReq.setDataNodeId(-1);
+    } else {
+      tFlushReq.setDataNodeId(config.getDataNodeId());

Review Comment:
   Standalone mode won’t check it, only flush the data in StorageEngine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org