[GitHub] [spark] stczwd commented on a change in pull request #35242: [SPARK-37933][SQL] Change the traversal method of V2ScanRelationPushDown push down rules

[GitBox <gi...@apache.org>]

stczwd commented on a change in pull request #35242:
URL: https://github.com/apache/spark/pull/35242#discussion_r787310124



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -222,7 +231,7 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan] with PredicateHelper {
       Cast(aggAttribute, aggDataType)
     }
 
-  def applyColumnPruning(plan: LogicalPlan): LogicalPlan = plan.transform {
+  def pushDownColumn(plan: LogicalPlan): LogicalPlan = plan.transform {

Review comment:
       `pruneColumns` sounds good to me, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org