You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jens-G <gi...@git.apache.org> on 2015/07/24 02:19:43 UTC

[GitHub] thrift pull request: THRIFT-3255 Thrift generator doesn't exclude ...

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/561

    THRIFT-3255 Thrift generator doesn't exclude 'package' keyword for Java

    The patch adds "package" to the global list of reserved keywords, because it is used as keyword in Java, ActionScript, Go, Haxe, Perl.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-3255

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #561
    
----
commit af85d6188d5d783f2f511692fc4048cf6ef318e7
Author: Jens Geyer <je...@apache.org>
Date:   2015-07-24T00:14:43Z

    THRIFT-3255 Thrift generator doesn't exclude 'package' keyword for thrift property names breaking java builds
    Client: Java
    Patch: Jens Geyer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3255 Thrift generator doesn't exclude ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/561


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---