You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/06 07:45:47 UTC

[GitHub] [pulsar] liudezhi2098 opened a new pull request, #15467: [enhancement][function-work] Suggestion put authenticateMetricsEndpoint in functions_worker.yml

liudezhi2098 opened a new pull request, #15467:
URL: https://github.com/apache/pulsar/pull/15467

   ### Motivation
   authenticateMetricsEndpoint configure will check  in functions worker, but the configuration is not placed in functions_worker.yml, for many users who do not know how to modify it, if authenticate turned on in functions worker.
   
   ### Modifications
   add conf 
   # Whether the '/metrics' endpoint requires authentication. Defaults to true
   authenticateMetricsEndpoint: true
   
   ### Documentation
   
   Need to update docs? 
   
   - [x] `no-need-doc` 
     
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #15467: [improve][fn] Suggestion put authenticateMetricsEndpoint in functions_worker conf

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #15467:
URL: https://github.com/apache/pulsar/pull/15467#issuecomment-1345420051

   Merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15467: [enhancement][function-work] Suggestion put authenticateMetricsEndpoint in functions_worker.yml

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15467:
URL: https://github.com/apache/pulsar/pull/15467#issuecomment-1148116282

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liudezhi2098 commented on pull request #15467: [enhancement][function-work] Suggestion put authenticateMetricsEndpoint in functions_worker.yml

Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on PR #15467:
URL: https://github.com/apache/pulsar/pull/15467#issuecomment-1120176321

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liudezhi2098 commented on pull request #15467: [enhancement][function-work] Suggestion put authenticateMetricsEndpoint in functions_worker.yml

Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on PR #15467:
URL: https://github.com/apache/pulsar/pull/15467#issuecomment-1120132719

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codecov-commenter commented on pull request #15467: [enhancement][function-work] Suggestion put authenticateMetricsEndpoint in functions_worker.yml

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #15467:
URL: https://github.com/apache/pulsar/pull/15467#issuecomment-1345282096

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/15467?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#15467](https://codecov.io/gh/apache/pulsar/pull/15467?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cabde9b) into [master](https://codecov.io/gh/apache/pulsar/commit/1b5722d35a2cbce35d1d0843fa6a999da5feb583?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b5722d) will **decrease** coverage by `9.29%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/15467/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/15467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #15467      +/-   ##
   ============================================
   - Coverage     46.34%   37.05%   -9.30%     
   + Complexity    10394     1968    -8426     
   ============================================
     Files           703      209     -494     
     Lines         68838    14425   -54413     
     Branches       7379     1574    -5805     
   ============================================
   - Hits          31905     5345   -26560     
   + Misses        33324     8493   -24831     
   + Partials       3609      587    -3022     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `37.05% <ø> (-9.30%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/15467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ulsar/broker/protocol/ProtocolHandlerMetadata.java](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9wcm90b2NvbC9Qcm90b2NvbEhhbmRsZXJNZXRhZGF0YS5qYXZh) | | |
   | [...pache/bookkeeper/mledger/impl/RangeSetWrapper.java](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL1JhbmdlU2V0V3JhcHBlci5qYXZh) | | |
   | [...broker/service/schema/BookkeeperSchemaStorage.java](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9Cb29ra2VlcGVyU2NoZW1hU3RvcmFnZS5qYXZh) | | |
   | [...rg/apache/pulsar/compaction/TwoPhaseCompactor.java](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbXBhY3Rpb24vVHdvUGhhc2VDb21wYWN0b3IuamF2YQ==) | | |
   | [...a/org/apache/pulsar/client/impl/RawReaderImpl.java](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Jhd1JlYWRlckltcGwuamF2YQ==) | | |
   | [...a/org/apache/pulsar/broker/admin/v1/Functions.java](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9GdW5jdGlvbnMuamF2YQ==) | | |
   | [...ava/org/apache/pulsar/broker/tools/BrokerTool.java](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90b29scy9Ccm9rZXJUb29sLmphdmE=) | | |
   | [...ava/org/apache/pulsar/broker/admin/v2/Bookies.java](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9Cb29raWVzLmphdmE=) | | |
   | [...ce/ConsistentHashingStickyKeyConsumerSelector.java](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0NvbnNpc3RlbnRIYXNoaW5nU3RpY2t5S2V5Q29uc3VtZXJTZWxlY3Rvci5qYXZh) | | |
   | [...org/apache/pulsar/broker/admin/impl/SinksBase.java](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL1NpbmtzQmFzZS5qYXZh) | | |
   | ... and [485 more](https://codecov.io/gh/apache/pulsar/pull/15467/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15467: [improve][fn] Suggestion put authenticateMetricsEndpoint in functions_worker conf

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15467:
URL: https://github.com/apache/pulsar/pull/15467#issuecomment-1345300902

   @liudezhi2098 Please add the following content to your PR description and select a checkbox:
   ```
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #15467: [improve][fn] Suggestion put authenticateMetricsEndpoint in functions_worker conf

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #15467:
URL: https://github.com/apache/pulsar/pull/15467#issuecomment-1345302208

   Confirm this is a config existing in `WorkerConfig`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun merged pull request #15467: [improve][fn] Suggestion put authenticateMetricsEndpoint in functions_worker conf

Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #15467:
URL: https://github.com/apache/pulsar/pull/15467


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org