You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/09/23 16:51:28 UTC
[GitHub] [geode] kirklund opened a new pull request #6898: 1.13: GEODE-9486: Fix validate-serializable-objects (#6823)
kirklund opened a new pull request #6898:
URL: https://github.com/apache/geode/pull/6898
Back port the fixes for GEODE-9486 to support/1.14:
-----------------------------------------------------------------------------
GEODE-9486: Fix validate-serializable-objects (#6823)
Rename DistributedSystemService to SanctionedSerializablesService and
remove unused init(DistributedSystem).
Move SanctionedSerializablesService to geode-serialization.
Implement SanctionedSerializablesService in both geode-core and
geode-management to remove special case for each in
InternalDataSerializer.
Fix sanctioned serializables support in geode-management and
geode-apis-compatible-with-redis.
Add sanctioned serializables support to geode-serialization and
geode-pulse.
Add sanctioned serializables support to geode-junit and geode-dunit
to simplify writing tests for validate-serializable-objects and prevent
having to list out DUnit Rules and other test framework classes when
validate-serializable-objects is enabled.
Use ExecutorServiceRule and reformat json strings in
RestRegionAPIIntegrationTest.
Reorganize QueryCommandDUnitTestBase.
Use InvalidClassException instead of Exception in
ObjectInputStreamFilterWrapper fatal log message.
Improve assertion messages in ResourceUtils.
Move loadSanctionedSerializablesServices and loadClassNames to
new SanctionedSerializables in geode-serialization.
Exclude Pulse GemFireAuthentication from sanctioned serializables.
Add SerializationTest Category to all AnalyzeSerializables integration
tests.
Tidy up SANCTIONED_SERIALIZABLES_DEPENDENCIES_PATTERN.
Convert to AssertJ and use BeforeClass in
InternalDataSerializerSerializationAcceptlistTest.
Note: If Git or GitHub is showing invalid file renames in the diffs, you
may need to pull the branch locally and configure diff.renameLimit to
something lower than the default value of 50.
(cherry picked from commit acbd0ff3c37a5e1fe3018d3f7288df385159ac4c)
(cherry picked from commit 8e569666b52d0179530a5c43e94c90e8c45de68f)
-----------------------------------------------------------------------------
GEODE-9486: Improve AnalyzeSerializables integration tests (#6878)
Allow geode modules to have an AnalyzeSerializables integration
test without implementing SanctionedSerializablesService.
Improve debugging information for AnalyzeSerializables integration
tests:
- Provide new failure message when no SanctionedSerializablesService
exists.
- Create ANALYZE_SERIALIZABLES.md to provide detailed instructions for
failures involving AnalyzeSerializables integration tests.
- Reference ANALYZE_SERIALIZABLES.md in failure messages.
Remove geode-serialization and geode-common jars from geode-pulse
.war file:
- Change getModuleClass() to return Optional.
- Delete PulseSanctionedSerializablesService and its resources.
- Change geode-pulse dependency on geode-serialization to be for
integrationTest only.
(cherry picked from commit 7bd1d73dcd02712a10e5c3f2ac5ac0522923bf9e)
(cherry picked from commit d13d6d8f51377290bc2cfc8ddf787b770e9fd4a9)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6898: 1.13: GEODE-9486: Fix validate-serializable-objects (#6823)
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6898:
URL: https://github.com/apache/geode/pull/6898#issuecomment-926857311
This pull request **fixes 2 alerts** when merging 318434b0acae49c423747c049db59fc2afa43735 into ccf0512e7475d554f23e0f556aab8a2ac8329562 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-70f1a097542e9cc5a3a72ef153596b976925eb73)
**fixed alerts:**
* 2 for Potential input resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund merged pull request #6898: 1.13: GEODE-9486: Fix validate-serializable-objects (#6823)
Posted by GitBox <gi...@apache.org>.
kirklund merged pull request #6898:
URL: https://github.com/apache/geode/pull/6898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund merged pull request #6898: 1.13: GEODE-9486: Fix validate-serializable-objects (#6823)
Posted by GitBox <gi...@apache.org>.
kirklund merged pull request #6898:
URL: https://github.com/apache/geode/pull/6898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6898: 1.13: GEODE-9486: Fix validate-serializable-objects (#6823)
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6898:
URL: https://github.com/apache/geode/pull/6898#issuecomment-926899497
This pull request **fixes 2 alerts** when merging d63eb22df7f3133ed531c3a89ec083976a5c014e into ccf0512e7475d554f23e0f556aab8a2ac8329562 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-027d6bece6af6db82824a4fb355c8d1665c91039)
**fixed alerts:**
* 2 for Potential input resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on pull request #6898: 1.13: GEODE-9486: Fix validate-serializable-objects (#6823)
Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #6898:
URL: https://github.com/apache/geode/pull/6898#issuecomment-929528050
Flaky test LocatorUDPSecurityDUnitTest had an unrelated failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6898: 1.13: GEODE-9486: Fix validate-serializable-objects (#6823)
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6898:
URL: https://github.com/apache/geode/pull/6898#issuecomment-929416385
This pull request **fixes 2 alerts** when merging fcf61e902a57c474db49f54930ade510a43f966a into ccf0512e7475d554f23e0f556aab8a2ac8329562 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-f6d41ac8f5f6fd547b2edef4d718c9b184b528d9)
**fixed alerts:**
* 2 for Potential input resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6898: 1.13: GEODE-9486: Fix validate-serializable-objects (#6823)
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6898:
URL: https://github.com/apache/geode/pull/6898#issuecomment-926018410
This pull request **fixes 2 alerts** when merging f630fddb59d7f9c0705736be048aeb7c7ccad357 into ccf0512e7475d554f23e0f556aab8a2ac8329562 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-8e1c3bb6bde65b8af30ba1280e029f23e8d7095f)
**fixed alerts:**
* 2 for Potential input resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on pull request #6898: 1.13: GEODE-9486: Fix validate-serializable-objects (#6823)
Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #6898:
URL: https://github.com/apache/geode/pull/6898#issuecomment-929528050
Flaky test LocatorUDPSecurityDUnitTest had an unrelated failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6898: 1.13: GEODE-9486: Fix validate-serializable-objects (#6823)
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6898:
URL: https://github.com/apache/geode/pull/6898#issuecomment-929416385
This pull request **fixes 2 alerts** when merging fcf61e902a57c474db49f54930ade510a43f966a into ccf0512e7475d554f23e0f556aab8a2ac8329562 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-f6d41ac8f5f6fd547b2edef4d718c9b184b528d9)
**fixed alerts:**
* 2 for Potential input resource leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org