You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Chris Harris (JIRA)" <ji...@apache.org> on 2009/12/04 22:53:20 UTC
[jira] Created: (SOLR-1624) Highlighter bug with MultiValued field
+ TermPositions optimization
Highlighter bug with MultiValued field + TermPositions optimization
-------------------------------------------------------------------
Key: SOLR-1624
URL: https://issues.apache.org/jira/browse/SOLR-1624
Project: Solr
Issue Type: Bug
Components: highlighter
Affects Versions: 1.4
Reporter: Chris Harris
When TermPositions are stored, then DefaultSolrHighlighter.doHighlighting(DocList docs, Query query, SolrQueryRequest req, String[] defaultFields) currently initializes tstream only for the first value of a multi-valued field. (Subsequent times through the loop reinitialization is preempted by tots being non-null.) This means that the 2nd/3rd/etc. values are not considered for highlighting purposes, resulting in missed highlights.
I'm attaching a patch with a test case to demonstrate the problem (testTermVecMultiValuedHighlight2), as well as a proposed fix. All highlighter tests pass with this applied. The patch should apply cleanly against the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1624) Highlighter bug with MultiValued field
+ TermPositions optimization
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved SOLR-1624.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.5
Committed. Thanks Chris!
> Highlighter bug with MultiValued field + TermPositions optimization
> -------------------------------------------------------------------
>
> Key: SOLR-1624
> URL: https://issues.apache.org/jira/browse/SOLR-1624
> Project: Solr
> Issue Type: Bug
> Components: highlighter
> Affects Versions: 1.4
> Reporter: Chris Harris
> Fix For: 1.5
>
> Attachments: SOLR-1624.patch
>
>
> When TermPositions are stored, then DefaultSolrHighlighter.doHighlighting(DocList docs, Query query, SolrQueryRequest req, String[] defaultFields) currently initializes tstream only for the first value of a multi-valued field. (Subsequent times through the loop reinitialization is preempted by tots being non-null.) This means that the 2nd/3rd/etc. values are not considered for highlighting purposes, resulting in missed highlights.
> I'm attaching a patch with a test case to demonstrate the problem (testTermVecMultiValuedHighlight2), as well as a proposed fix. All highlighter tests pass with this applied. The patch should apply cleanly against the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1624) Highlighter bug with MultiValued field
+ TermPositions optimization
Posted by "Chris Harris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Harris updated SOLR-1624:
-------------------------------
Attachment: SOLR-1624.patch
> Highlighter bug with MultiValued field + TermPositions optimization
> -------------------------------------------------------------------
>
> Key: SOLR-1624
> URL: https://issues.apache.org/jira/browse/SOLR-1624
> Project: Solr
> Issue Type: Bug
> Components: highlighter
> Affects Versions: 1.4
> Reporter: Chris Harris
> Attachments: SOLR-1624.patch
>
>
> When TermPositions are stored, then DefaultSolrHighlighter.doHighlighting(DocList docs, Query query, SolrQueryRequest req, String[] defaultFields) currently initializes tstream only for the first value of a multi-valued field. (Subsequent times through the loop reinitialization is preempted by tots being non-null.) This means that the 2nd/3rd/etc. values are not considered for highlighting purposes, resulting in missed highlights.
> I'm attaching a patch with a test case to demonstrate the problem (testTermVecMultiValuedHighlight2), as well as a proposed fix. All highlighter tests pass with this applied. The patch should apply cleanly against the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.