You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/04/29 04:09:48 UTC
Review Request 33657: Edit Widget: Display name of a widget is not
updated
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33657/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-10814
https://issues.apache.org/jira/browse/AMBARI-10814
Repository: ambari
Description
-------
Updating a widget by using PUT method on widget API updates description, metrics, properties attribute successfully but does not update display_name.
Diffs
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 1682a00
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json 9af9e2b
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 5731c7e
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json 7b67cd8
ambari-server/src/main/resources/stacks/HDP/2.0.6/widgets.json 2343616
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/widgets.json db5aee1
ambari-web/app/app.js abb826b
ambari-web/app/controllers/main/service/widgets/create/step3_controller.js a8134a9
ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js ad66f4e
ambari-web/app/controllers/main/service/widgets/edit_controller.js 402c8a7
ambari-web/app/mappers/widget_mapper.js 695a57e
ambari-web/app/mixins/common/widgets/widget_mixin.js 8e5e110
ambari-web/app/models/widget.js 5dbd685
ambari-web/app/routes/main.js 42fb206
ambari-web/app/templates/common/modal_popups/widget_browser_popup.hbs 0b88018
ambari-web/app/templates/common/widget/gauge_widget.hbs 7ba1600
ambari-web/app/templates/common/widget/graph_widget.hbs 6fffd92
ambari-web/app/templates/common/widget/heatmap_widget.hbs 215fb1c
ambari-web/app/templates/common/widget/number_widget.hbs 6bb82e3
ambari-web/app/templates/common/widget/template_widget.hbs 0d5cc27
ambari-web/app/templates/main/charts/heatmap_dropdown.hbs 8904d49
ambari-web/app/templates/main/service/info/heatmap_dropdown.hbs 8986c45
ambari-web/app/templates/main/service/widgets/create/step3.hbs 47beb74
ambari-web/app/utils/helper.js 5606192
ambari-web/app/views/common/widget/gauge_widget_view.js 3acfa10
ambari-web/app/views/common/widget/graph_widget_view.js bfe8306
ambari-web/app/views/common/widget/number_widget_view.js fc8a53b
ambari-web/app/views/main/service/item.js 1abac49
Diff: https://reviews.apache.org/r/33657/diff/
Testing
-------
Tested manually on a cluster
verified that unit test passess
Thanks,
Jaimin Jetly
Re: Review Request 33657: Edit Widget: Display name of a widget is not
updated
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33657/#review81919
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On April 29, 2015, 2:09 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33657/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 2:09 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-10814
> https://issues.apache.org/jira/browse/AMBARI-10814
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Updating a widget by using PUT method on widget API updates description, metrics, properties attribute successfully but does not update display_name.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 1682a00
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json 9af9e2b
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 5731c7e
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json 7b67cd8
> ambari-server/src/main/resources/stacks/HDP/2.0.6/widgets.json 2343616
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/widgets.json db5aee1
> ambari-web/app/app.js abb826b
> ambari-web/app/controllers/main/service/widgets/create/step3_controller.js a8134a9
> ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js ad66f4e
> ambari-web/app/controllers/main/service/widgets/edit_controller.js 402c8a7
> ambari-web/app/mappers/widget_mapper.js 695a57e
> ambari-web/app/mixins/common/widgets/widget_mixin.js 8e5e110
> ambari-web/app/models/widget.js 5dbd685
> ambari-web/app/routes/main.js 42fb206
> ambari-web/app/templates/common/modal_popups/widget_browser_popup.hbs 0b88018
> ambari-web/app/templates/common/widget/gauge_widget.hbs 7ba1600
> ambari-web/app/templates/common/widget/graph_widget.hbs 6fffd92
> ambari-web/app/templates/common/widget/heatmap_widget.hbs 215fb1c
> ambari-web/app/templates/common/widget/number_widget.hbs 6bb82e3
> ambari-web/app/templates/common/widget/template_widget.hbs 0d5cc27
> ambari-web/app/templates/main/charts/heatmap_dropdown.hbs 8904d49
> ambari-web/app/templates/main/service/info/heatmap_dropdown.hbs 8986c45
> ambari-web/app/templates/main/service/widgets/create/step3.hbs 47beb74
> ambari-web/app/utils/helper.js 5606192
> ambari-web/app/views/common/widget/gauge_widget_view.js 3acfa10
> ambari-web/app/views/common/widget/graph_widget_view.js bfe8306
> ambari-web/app/views/common/widget/number_widget_view.js fc8a53b
> ambari-web/app/views/main/service/item.js 1abac49
>
> Diff: https://reviews.apache.org/r/33657/diff/
>
>
> Testing
> -------
>
> Tested manually on a cluster
> verified that unit test passess
>
>
> Thanks,
>
> Jaimin Jetly
>
>