You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "lucifer4j (via GitHub)" <gi...@apache.org> on 2023/06/30 06:38:47 UTC
[GitHub] [pinot] lucifer4j opened a new pull request, #11013: Add fromController method that accepts a PinotClientTransport
lucifer4j opened a new pull request, #11013:
URL: https://github.com/apache/pinot/pull/11013
`feature` (partially fixes #10924).
`ConnectionFactory` class is used to create instances on pinot client's `Connection` class. There are different methods available depending upon the kind of broker that we want to use. All of these except `fromController` also provide a variant to accept a `PinotClientTransport` from the user.
We are wrapping around the `ConnectionFactory` class in the Vert.x wrapper for pinot client to provide our custom transport. Since the constructors of the `Connection` class are package-private, we cannot directly add this method to an external package. Further, this method seems to be absent from the class only as a mistake (there are methods to specify custom transports with all other brokers).
Hence, adding this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11013: Add fromController method that accepts a PinotClientTransport
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11013:
URL: https://github.com/apache/pinot/pull/11013#issuecomment-1614248658
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11013?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11013](https://app.codecov.io/gh/apache/pinot/pull/11013?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (44f526b) into [master](https://app.codecov.io/gh/apache/pinot/commit/379d7610ac58724d1dcfe5968ddad8bb37a988d3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (379d761) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #11013 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2192 2192
Lines 118016 118019 +3
Branches 17869 17869
==========================================
Hits 137 137
- Misses 117859 117862 +3
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `0.00% <0.00%> (ø)` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `0.11% <0.00%> (ø)` | |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/11013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/pinot/client/ConnectionFactory.java](https://app.codecov.io/gh/apache/pinot/pull/11013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb25GYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #11013: Add fromController method that accepts a PinotClientTransport
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11013:
URL: https://github.com/apache/pinot/pull/11013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org