You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2014/07/09 17:04:37 UTC

[GitHub] incubator-brooklyn pull request: Fix for brooklyn.rest.resources.S...

GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/58

    Fix for brooklyn.rest.resources.SensorResourceTest.testGetPlain error.

    Failing with expected "12345 frogs" but got "12345". The tearDown in EntityResourceTest
    was cleaning the renderer registry in the middle of executing SensorResourceTests' methods.
    
    Turns out TestNG interleaves the tests from separate classes in a single thread (the execution is sequential).
    
    EntityResourceTest seems like copy&pasted from SensorResourceTest with the tearDown
    call not needed, removed tearDown and unrelated comments.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn sensor-renderer-test-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 860a939b080890139763251baf32fe673ebce681
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-07-09T15:02:18Z

    Fix for brooklyn.rest.resources.SensorResourceTest.testGetPlain error.
    
    Failing with expected "12345 frogs" but got "12345". The tearDown in EntityResourceTest
    was cleaning the renderer registry in the middle of executing SensorResourceTests' methods.
    Turns out TestNG interleaves the tests from separate classes in a single thread (the execution is sequential).
    EntityResourceTest seems like copy&pasted from SensorResourceTest with the tearDown
    call not needed, removed tearDown and unrelated comments.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix for brooklyn.rest.resources.S...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/58#issuecomment-48526633
  
    Looks good; merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix for brooklyn.rest.resources.S...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/58


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---