You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/09/22 16:01:40 UTC

Review Request 38625: Keep clone syscall consistent.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/
-----------------------------------------------------------

Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.


Bugs: MESOS-3474
    https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
-------

Keep clone syscall consistent.


Diffs
-----

  src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
  src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
  src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 

Diff: https://reviews.apache.org/r/38625/diff/


Testing
-------

sudo make -j8 check


Thanks,

haosdent huang

Re: Review Request 38625: Keep clone syscall consistent.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review99991
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38625]

All tests passed.

- Mesos ReviewBot


On Sept. 22, 2015, 2:01 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 2:01 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Keep clone syscall consistent.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> -------
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Keep clone syscall consistent.

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 22, 2015, 4:51 p.m., Cong Wang wrote:
> > Why not introduce a wrapper for clone() to hide the 'stack'?

Sure, let me update again.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100012
-----------------------------------------------------------


On Sept. 22, 2015, 2:01 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 2:01 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Keep clone syscall consistent.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> -------
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Replace clone system call with os::clone

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 22, 2015, 4:51 p.m., Cong Wang wrote:
> > Why not introduce a wrapper for clone() to hide the 'stack'?
> 
> haosdent huang wrote:
>     Sure, let me update again.

@wangcong I finish update the patch. Could you help review this again? Thank you very much.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100012
-----------------------------------------------------------


On Sept. 22, 2015, 6:52 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace clone system call with os::clone.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> -------
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Keep clone syscall consistent.

Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100012
-----------------------------------------------------------


Why not introduce a wrapper for clone() to hide the 'stack'?

- Cong Wang


On Sept. 22, 2015, 2:01 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 2:01 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Keep clone syscall consistent.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> -------
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Replace clone system call with os::clone

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100050
-----------------------------------------------------------

Ship it!



src/tests/containerizer/ns_tests.cpp (lines 169 - 171)
<https://reviews.apache.org/r/38625/#comment157141>

    Maybe
    
    ```
    pid_t pid = os::clone(
        lambda::bind(&childGetns, NULL),
        nstype.get() | SIGCHLD);
    ```



src/tests/containerizer/ns_tests.cpp (lines 223 - 225)
<https://reviews.apache.org/r/38625/#comment157142>

    Ditto.


- Jie Yu


On Sept. 22, 2015, 6:52 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace clone system call with os::clone.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> -------
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Replace clone system call with os::clone

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100128
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38639, 38625]

All tests passed.

- Mesos ReviewBot


On Sept. 23, 2015, 1:25 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 1:25 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace clone system call with os::clone.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> -------
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Replace clone system call with os::clone

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/
-----------------------------------------------------------

(Updated Sept. 23, 2015, 1:25 a.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.


Changes
-------

Update according @jieyu's reviews.


Bugs: MESOS-3474
    https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
-------

Replace clone system call with os::clone.


Diffs (updated)
-----

  src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
  src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
  src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 

Diff: https://reviews.apache.org/r/38625/diff/


Testing
-------

sudo make -j8 check


Thanks,

haosdent huang

Re: Review Request 38625: Replace clone system call with os::clone

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100068
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38639, 38625]

All tests passed.

- Mesos ReviewBot


On Sept. 22, 2015, 6:52 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace clone system call with os::clone.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> -------
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Replace clone system call with os::clone

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 6:52 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.


Changes
-------

Update desc.


Summary (updated)
-----------------

Replace clone system call with os::clone


Bugs: MESOS-3474
    https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description (updated)
-------

Replace clone system call with os::clone.


Diffs (updated)
-----

  src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
  src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
  src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 

Diff: https://reviews.apache.org/r/38625/diff/


Testing
-------

sudo make -j8 check


Thanks,

haosdent huang

Re: Review Request 38625: Keep clone syscall consistent.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 6:38 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.


Bugs: MESOS-3474
    https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
-------

Keep clone syscall consistent.


Diffs (updated)
-----

  src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
  src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
  src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 

Diff: https://reviews.apache.org/r/38625/diff/


Testing
-------

sudo make -j8 check


Thanks,

haosdent huang

Re: Review Request 38625: Keep clone syscall consistent.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 6:37 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and Cong Wang.


Bugs: MESOS-3474
    https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
-------

Keep clone syscall consistent.


Diffs (updated)
-----

  src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26 
  src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
  src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 

Diff: https://reviews.apache.org/r/38625/diff/


Testing
-------

sudo make -j8 check


Thanks,

haosdent huang