You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/26 13:28:46 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #21212: chore: Keeps context menu in viewport
michael-s-molina opened a new pull request, #21212:
URL: https://github.com/apache/superset/pull/21212
### SUMMARY
This PR is an improvement to the right-click interactions on charts. It makes the context menu always display in the viewport to avoid the need for scrolling and to keep all options always visible.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/186914003-8cdc1e65-687f-4a6a-9b58-30ab3692d8b3.mov
### TESTING INSTRUCTIONS
Check the video for instructions.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21212: chore: Keeps context menu in viewport
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21212:
URL: https://github.com/apache/superset/pull/21212#issuecomment-1228610763
Storybook has completed and can be viewed at
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #21212: chore: Keeps context menu in viewport
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #21212:
URL: https://github.com/apache/superset/pull/21212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21212: chore: Keeps context menu in viewport
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21212:
URL: https://github.com/apache/superset/pull/21212#issuecomment-1228753246
# [Codecov](https://codecov.io/gh/apache/superset/pull/21212?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21212](https://codecov.io/gh/apache/superset/pull/21212?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea8984c) into [master](https://codecov.io/gh/apache/superset/commit/68fa4d2665cc0742b2194533271ce562a3ebbf14?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68fa4d2) will **decrease** coverage by `0.00%`.
> The diff coverage is `22.22%`.
```diff
@@ Coverage Diff @@
## master #21212 +/- ##
==========================================
- Coverage 66.36% 66.36% -0.01%
==========================================
Files 1781 1781
Lines 67930 67938 +8
Branches 7255 7258 +3
==========================================
+ Hits 45085 45087 +2
- Misses 20982 20988 +6
Partials 1863 1863
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.26% <22.22%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/Chart/ChartContextMenu.tsx](https://codecov.io/gh/apache/superset/pull/21212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvQ2hhcnRDb250ZXh0TWVudS50c3g=) | `44.00% <22.22%> (-8.95%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21212: chore: Keeps context menu in viewport
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21212:
URL: https://github.com/apache/superset/pull/21212#issuecomment-1228718676
Storybook has completed and can be viewed at
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org