[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4733: [WIP] Introduce Kafka event logger for server events

["bowenliang123 (via GitHub)" <gi...@apache.org>]

bowenliang123 commented on code in PR #4733:
URL: https://github.com/apache/kyuubi/pull/4733#discussion_r1178517923


##########
kyuubi-server/src/test/scala/org/apache/kyuubi/events/handler/ServerJsonLoggingEventHandlerSuite.scala:
##########
@@ -197,6 +198,7 @@ class ServerJsonLoggingEventHandlerSuite extends WithKyuubiServer with HiveJDBCT
     server.initialize(conf)
     server.start()
     server.stop()
+    ServerEventHandlerRegister.registerEventLoggers(conf)

Review Comment:
   According to @wForget 's advice, stopping the server in line 200 will also clear the event handlers in the singleton of EventBus. Re-register the event loggers here helps for continuing sending to existed event logger in server for the whole testsuite.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org