You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2015/01/19 16:53:32 UTC
Review Request 30035: Part of Validation string-type configs in MR2
does not work at Installation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30035/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Srimanth Gunturi, and Yusaku Sako.
Bugs: AMBARI-9196
https://issues.apache.org/jira/browse/AMBARI-9196
Repository: ambari
Description
-------
STR:
# *On installer phase -> "Customize Services" step*
# Navigate on MR2 tab
# Change :
mapreduce.map.java.opts= -Xmxm (Invalid)
mapreduce.reduce.java.opts= -Xmx0m (Less)
yarn.app.mapreduce.am.command-opts= -Xmx545m (Less)
# Check validation
Actual result:
Have not "Less" and Invalid validate messages on UI.
Expected result:
Have all validate messages on UI.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 06e66a6
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py f387bd1
Diff: https://reviews.apache.org/r/30035/diff/
Testing
-------
Tests ok
Thanks,
Yurii Shylov
Re: Review Request 30035: Part of Validation string-type configs in
MR2 does not work at Installation
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30035/#review69220
-----------------------------------------------------------
I see the unit tests are failing. Yurii can you please take a look?
- Mahadev Konar
On Jan. 19, 2015, 3:53 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30035/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2015, 3:53 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-9196
> https://issues.apache.org/jira/browse/AMBARI-9196
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> # *On installer phase -> "Customize Services" step*
> # Navigate on MR2 tab
> # Change :
> mapreduce.map.java.opts= -Xmxm (Invalid)
> mapreduce.reduce.java.opts= -Xmx0m (Less)
> yarn.app.mapreduce.am.command-opts= -Xmx545m (Less)
> # Check validation
>
>
> Actual result:
> Have not "Less" and Invalid validate messages on UI.
>
> Expected result:
> Have all validate messages on UI.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 06e66a6
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py f387bd1
>
> Diff: https://reviews.apache.org/r/30035/diff/
>
>
> Testing
> -------
>
> Tests ok
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30035: Part of Validation string-type configs in
MR2 does not work at Installation
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30035/#review69216
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On Jan. 19, 2015, 3:53 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30035/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2015, 3:53 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-9196
> https://issues.apache.org/jira/browse/AMBARI-9196
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> # *On installer phase -> "Customize Services" step*
> # Navigate on MR2 tab
> # Change :
> mapreduce.map.java.opts= -Xmxm (Invalid)
> mapreduce.reduce.java.opts= -Xmx0m (Less)
> yarn.app.mapreduce.am.command-opts= -Xmx545m (Less)
> # Check validation
>
>
> Actual result:
> Have not "Less" and Invalid validate messages on UI.
>
> Expected result:
> Have all validate messages on UI.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 06e66a6
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py f387bd1
>
> Diff: https://reviews.apache.org/r/30035/diff/
>
>
> Testing
> -------
>
> Tests ok
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30035: Part of Validation string-type configs in
MR2 does not work at Installation
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30035/#review68617
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 19, 2015, 3:53 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30035/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2015, 3:53 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-9196
> https://issues.apache.org/jira/browse/AMBARI-9196
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> # *On installer phase -> "Customize Services" step*
> # Navigate on MR2 tab
> # Change :
> mapreduce.map.java.opts= -Xmxm (Invalid)
> mapreduce.reduce.java.opts= -Xmx0m (Less)
> yarn.app.mapreduce.am.command-opts= -Xmx545m (Less)
> # Check validation
>
>
> Actual result:
> Have not "Less" and Invalid validate messages on UI.
>
> Expected result:
> Have all validate messages on UI.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 06e66a6
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py f387bd1
>
> Diff: https://reviews.apache.org/r/30035/diff/
>
>
> Testing
> -------
>
> Tests ok
>
>
> Thanks,
>
> Yurii Shylov
>
>