You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "agingade (GitHub)" <gi...@apache.org> on 2018/12/05 20:04:58 UTC
[GitHub] [geode] agingade opened pull request #2953: GEODE-6032: Updated javadoc to clarify what is communicated with hasD…
### For all changes:
- [Yes] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [Yes] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [Yes] Is your initial contribution a single, squashed commit?
- [Yes] Does `gradlew build` run cleanly?
- [NA] Have you written or updated unit tests to verify your changes?
- [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] agingade commented on pull request #2953: GEODE-6032: Updated javadoc to clarify what is communicated with hasD…
Posted by "agingade (GitHub)" <gi...@apache.org>.
New commit has the requested changes.
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jxblum commented on issue #2953: GEODE-6032: Updated javadoc to clarify what is communicated with hasD…
Posted by "jxblum (GitHub)" <gi...@apache.org>.
See my [recent comment](https://issues.apache.org/jira/browse/GEODE-6032?focusedCommentId=16710787&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16710787) on GEODE-6032.
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt commented on pull request #2953: GEODE-6032: Updated javadoc to clarify what is communicated with hasD…
Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
You're missing an article. You have "write out as delta" but you should have "write out as a delta".
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on pull request #2953: GEODE-6032: Updated javadoc to clarify what is communicated with hasD…
Posted by "kirklund (GitHub)" <gi...@apache.org>.
Here's my version:
```
Returns true if this object has pending changes that can be transmitted as a delta.
```
If that's not enough then maybe:
```
Returns true if this object has pending changes that can be transmitted as a delta. Returns false if this object must be transmitted in its entirety.
```
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] agingade closed pull request #2953: GEODE-6032: Updated javadoc to clarify what is communicated with hasD…
Posted by "agingade (GitHub)" <gi...@apache.org>.
[ pull request closed by agingade ]
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] agingade commented on pull request #2953: GEODE-6032: Updated javadoc to clarify what is communicated with hasD…
Posted by "agingade (GitHub)" <gi...@apache.org>.
Thanks Bruce. I wanted to make it clear what is communicated based on hasDelta().
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on pull request #2953: GEODE-6032: Updated javadoc to clarify what is communicated with hasD…
Posted by "kirklund (GitHub)" <gi...@apache.org>.
Here's my version:
_Returns true if this object has pending changes that can be transmitted as a delta._
If that's not enough then maybe:
_Returns true if this object has pending changes that can be transmitted as a delta. Returns false if this object must be transmitted in its entirety._
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt commented on pull request #2953: GEODE-6032: Updated javadoc to clarify what is communicated with hasD…
Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
I'm sorry but this javadoc doesn't seem at all clear to me and it has grammatical errors. I think you should keep the original Javadoc and append something like this:
_Returns false if pending changes are not available, which will cause the entire object to be transmitted to other processes._
[ Full content available at: https://github.com/apache/geode/pull/2953 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org