[GitHub] spark issue #16495: SPARK-16920: Add a stress test for evaluateEachIteration...

[vlad17 <gi...@git.apache.org>]

Github user vlad17 commented on the issue:

    https://github.com/apache/spark/pull/16495
  
    Yes, sorry for my wording. A unit test is indeed an inappropriate place for stress tests. An offline test would be sufficient to verify that an O(N) implementation is an improvement over the O(N^2) one. Ideally the stress test would be neatly described in the PR message so that anyone could replicate, perhaps even linking to a gist with the script to run it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org