You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/24 09:48:29 UTC

[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request #4915: Refactor UI for orchestration

menghaoranss opened a new pull request #4915: Refactor UI for orchestration
URL: https://github.com/apache/incubator-shardingsphere/pull/4915
 
 
   Fixes #3873 .
   
   Changes proposed in this pull request:
   - refactor the menus structure to: 
   ```
   /
   ├─Config Center
        ├─Config Server
        ├─Rule Config
   ├─Registry Center
        ├─Config Server
        ├─Runtime Status  
   └─Data scaling 
   ```
   - refactor API,split into config center and registry center api
   - modify `shardingsphere-ui-configs.yaml` file structure to:
   ```
   centerConfigs:
   - activated: true
     digest: ''
     instanceType: Zookeeper
     name: registry-1
     namespace: orchestration_proxy
     orchestrationName: orchestration_ds
     orchestrationType: registry_center
     props: {}
     serverLists: 127.0.0.1:2181
   - activated: true
     digest: ''
     instanceType: Zookeeper
     name: config-1
     namespace: orchestration_proxy
     orchestrationName: orchestration_ds
     orchestrationType: config_center
     props: {}
     serverLists: 127.0.0.1:2181
   ```
   - optimize part of the code, including renaming classname and using lambda expression

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4915: Refactor UI for orchestration

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4915: Refactor UI for orchestration
URL: https://github.com/apache/incubator-shardingsphere/pull/4915#issuecomment-603149871
 
 
   ## Pull Request Test Coverage Report for [Build 10533](https://coveralls.io/builds/29581980)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **30** unchanged lines in **6** files lost coverage.
   * Overall coverage decreased (**-0.08%**) to **58.047%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/engine/ShardingSQLRewriteEngine.java](https://coveralls.io/builds/29581980/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fengine%2FShardingSQLRewriteEngine.java#L71) | 1 | 94.44% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/TableRule.java](https://coveralls.io/builds/29581980/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FTableRule.java#L164) | 3 | 90.53% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29581980/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29581980/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/29581980/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L374) | 8 | 85.21% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29581980/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% |
   <!-- | **Total:** | **30** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29581980/badge)](https://coveralls.io/builds/29581980) |
   | :-- | --: |
   | Change from base [Build 1155](https://coveralls.io/builds/29574204): |  -0.08% |
   | Covered Lines: | 11873 |
   | Relevant Lines: | 20454 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4915: Refactor UI for orchestration

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4915: Refactor UI for orchestration
URL: https://github.com/apache/incubator-shardingsphere/pull/4915
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4915: Refactor UI for orchestration

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4915: Refactor UI for orchestration
URL: https://github.com/apache/incubator-shardingsphere/pull/4915#issuecomment-603149871
 
 
   ## Pull Request Test Coverage Report for [Build 10525](https://coveralls.io/builds/29575130)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **18** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.08%**) to **58.049%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29575130/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29575130/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29575130/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% |
   <!-- | **Total:** | **18** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29575130/badge)](https://coveralls.io/builds/29575130) |
   | :-- | --: |
   | Change from base [Build 1155](https://coveralls.io/builds/29574204): |  -0.08% |
   | Covered Lines: | 11874 |
   | Relevant Lines: | 20455 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services