You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ulysses-you (via GitHub)" <gi...@apache.org> on 2023/11/29 07:36:37 UTC
[PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
ulysses-you opened a new pull request, #44074:
URL: https://github.com/apache/spark/pull/44074
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This pr adds a new extension entrance `queryPostPlannerStrategyRules` in `SparkSessionExtensions`. It will be applied between plannerStrategy and queryStagePrepRules in AQE, so it can get the whole plan before injecting exchanges.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
a part of https://github.com/apache/spark/pull/44013
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no, only for develop
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
add test
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1409762593
##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:
##########
@@ -516,6 +518,33 @@ class SparkSessionExtensionSuite extends SparkFunSuite with SQLHelper with Adapt
}
}
}
+
+ test("SPARK-46170: Support inject adaptive query post planner strategy rules in " +
+ "SparkSessionExtensions") {
+ val extensions = create { extensions =>
+ extensions.injectQueryPostPlannerStrategyRule(_ => MyQueryPostPlannerStrategyRule)
+ }
+ withSession(extensions) { session =>
+ assert(session.sessionState.adaptiveRulesHolder.queryPostPlannerStrategyRules
+ .contains(MyQueryPostPlannerStrategyRule))
+ import session.sqlContext.implicits._
+ withSQLConf(SQLConf.SHUFFLE_PARTITIONS.key -> "3",
+ SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "false") {
+ val input = Seq((10), (20), (10)).toDF("c1")
Review Comment:
Why is it necessary to add parentheses to each element? for readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1409794398
##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:
##########
@@ -516,6 +518,33 @@ class SparkSessionExtensionSuite extends SparkFunSuite with SQLHelper with Adapt
}
}
}
+
+ test("SPARK-46170: Support inject adaptive query post planner strategy rules in " +
+ "SparkSessionExtensions") {
+ val extensions = create { extensions =>
+ extensions.injectQueryPostPlannerStrategyRule(_ => MyQueryPostPlannerStrategyRule)
+ }
+ withSession(extensions) { session =>
+ assert(session.sessionState.adaptiveRulesHolder.queryPostPlannerStrategyRules
+ .contains(MyQueryPostPlannerStrategyRule))
+ import session.sqlContext.implicits._
+ withSQLConf(SQLConf.SHUFFLE_PARTITIONS.key -> "3",
+ SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "false") {
+ val input = Seq((10), (20), (10)).toDF("c1")
+ val df = input.groupBy("c1").count()
+ df.collect()
+ assert(df.rdd.partitions.length == 1)
+ assert(find(df.queryExecution.executedPlan) {
+ case s: ShuffleExchangeExec if s.outputPartitioning == SinglePartition => true
+ case _ => false
+ }.isDefined)
+ assert(find(df.queryExecution.executedPlan) {
Review Comment:
Seems using `collectFirst` could eliminate the `case _ => false` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1409595327
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala:
##########
@@ -114,12 +115,15 @@ class SparkSessionExtensions {
type ColumnarRuleBuilder = SparkSession => ColumnarRule
type QueryStagePrepRuleBuilder = SparkSession => Rule[SparkPlan]
type QueryStageOptimizerRuleBuilder = SparkSession => Rule[SparkPlan]
+ type QueryPostPlannerStrategyBuilder = SparkSession => Rule[SparkPlan]
Review Comment:
Shall we put this before `type QueryStagePrepRuleBuilder` because this rule is supposed to be used before `queryStagePreparationRules`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1409761044
##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:
##########
@@ -516,6 +518,33 @@ class SparkSessionExtensionSuite extends SparkFunSuite with SQLHelper with Adapt
}
}
}
+
+ test("SPARK-46170: Support inject adaptive query post planner strategy rules in " +
+ "SparkSessionExtensions") {
+ val extensions = create { extensions =>
+ extensions.injectQueryPostPlannerStrategyRule(_ => MyQueryPostPlannerStrategyRule)
+ }
+ withSession(extensions) { session =>
+ assert(session.sessionState.adaptiveRulesHolder.queryPostPlannerStrategyRules
+ .contains(MyQueryPostPlannerStrategyRule))
+ import session.sqlContext.implicits._
Review Comment:
how about just use `session.implicits._`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you closed pull request #44074: [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions
URL: https://github.com/apache/spark/pull/44074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1410076039
##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:
##########
@@ -516,6 +518,33 @@ class SparkSessionExtensionSuite extends SparkFunSuite with SQLHelper with Adapt
}
}
}
+
+ test("SPARK-46170: Support inject adaptive query post planner strategy rules in " +
+ "SparkSessionExtensions") {
+ val extensions = create { extensions =>
+ extensions.injectQueryPostPlannerStrategyRule(_ => MyQueryPostPlannerStrategyRule)
+ }
+ withSession(extensions) { session =>
+ assert(session.sessionState.adaptiveRulesHolder.queryPostPlannerStrategyRules
+ .contains(MyQueryPostPlannerStrategyRule))
+ import session.sqlContext.implicits._
+ withSQLConf(SQLConf.SHUFFLE_PARTITIONS.key -> "3",
+ SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "false") {
+ val input = Seq((10), (20), (10)).toDF("c1")
+ val df = input.groupBy("c1").count()
+ df.collect()
Review Comment:
it is used to make sure we are checking the final plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1409597388
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala:
##########
@@ -114,12 +115,15 @@ class SparkSessionExtensions {
type ColumnarRuleBuilder = SparkSession => ColumnarRule
type QueryStagePrepRuleBuilder = SparkSession => Rule[SparkPlan]
type QueryStageOptimizerRuleBuilder = SparkSession => Rule[SparkPlan]
+ type QueryPostPlannerStrategyBuilder = SparkSession => Rule[SparkPlan]
private[this] val columnarRuleBuilders = mutable.Buffer.empty[ColumnarRuleBuilder]
private[this] val queryStagePrepRuleBuilders = mutable.Buffer.empty[QueryStagePrepRuleBuilder]
private[this] val runtimeOptimizerRules = mutable.Buffer.empty[RuleBuilder]
private[this] val queryStageOptimizerRuleBuilders =
mutable.Buffer.empty[QueryStageOptimizerRuleBuilder]
+ private[this] val queryPostPlannerStrategyRuleBuilders =
+ mutable.Buffer.empty[QueryPostPlannerStrategyBuilder]
Review Comment:
Ditto. Shall we put this before `private[this] val queryStagePrepRuleBuilders`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1409781928
##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:
##########
@@ -516,6 +518,33 @@ class SparkSessionExtensionSuite extends SparkFunSuite with SQLHelper with Adapt
}
}
}
+
+ test("SPARK-46170: Support inject adaptive query post planner strategy rules in " +
+ "SparkSessionExtensions") {
+ val extensions = create { extensions =>
+ extensions.injectQueryPostPlannerStrategyRule(_ => MyQueryPostPlannerStrategyRule)
+ }
+ withSession(extensions) { session =>
+ assert(session.sessionState.adaptiveRulesHolder.queryPostPlannerStrategyRules
+ .contains(MyQueryPostPlannerStrategyRule))
+ import session.sqlContext.implicits._
+ withSQLConf(SQLConf.SHUFFLE_PARTITIONS.key -> "3",
+ SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "false") {
+ val input = Seq((10), (20), (10)).toDF("c1")
+ val df = input.groupBy("c1").count()
+ df.collect()
+ assert(df.rdd.partitions.length == 1)
+ assert(find(df.queryExecution.executedPlan) {
+ case s: ShuffleExchangeExec if s.outputPartitioning == SinglePartition => true
Review Comment:
How about `case s: ShuffleExchangeExec => s.outputPartitioning == SinglePartition`
Additionally, a personal opinion unrelated to this pr: If there is an `exists` function in `AdaptiveSparkPlanHelper,` would this assertion be simpler to write?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #44074:
URL: https://github.com/apache/spark/pull/44074#issuecomment-1832996246
thank you @dongjoon-hyun @LuciferYang , addressed comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #44074:
URL: https://github.com/apache/spark/pull/44074#issuecomment-1831367808
cc @dongjoon-hyun @cloud-fan this pr is only for adding Adaptive Query Post Planner Strategy Rules part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #44074:
URL: https://github.com/apache/spark/pull/44074#issuecomment-1831368538
CI link https://github.com/ulysses-you/spark/actions/runs/7029365126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1409598886
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala:
##########
@@ -185,6 +197,15 @@ class SparkSessionExtensions {
queryStageOptimizerRuleBuilders += builder
}
+ /**
+ * Inject a rule that applied between `plannerStrategy` and `queryStagePrepRules`, so
+ * it can get the whole plan before injecting exchanges.
+ * Note, these rules can only be applied within AQE.
+ */
+ def injectQueryPostPlannerStrategyRule(builder: QueryPostPlannerStrategyBuilder): Unit = {
+ queryPostPlannerStrategyRuleBuilders += builder
+ }
+
Review Comment:
ditto. Shall we put this before `def injectQueryStagePrepRule`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1409772748
##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:
##########
@@ -516,6 +518,33 @@ class SparkSessionExtensionSuite extends SparkFunSuite with SQLHelper with Adapt
}
}
}
+
+ test("SPARK-46170: Support inject adaptive query post planner strategy rules in " +
+ "SparkSessionExtensions") {
+ val extensions = create { extensions =>
+ extensions.injectQueryPostPlannerStrategyRule(_ => MyQueryPostPlannerStrategyRule)
+ }
+ withSession(extensions) { session =>
+ assert(session.sessionState.adaptiveRulesHolder.queryPostPlannerStrategyRules
+ .contains(MyQueryPostPlannerStrategyRule))
+ import session.sqlContext.implicits._
+ withSQLConf(SQLConf.SHUFFLE_PARTITIONS.key -> "3",
+ SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "false") {
+ val input = Seq((10), (20), (10)).toDF("c1")
+ val df = input.groupBy("c1").count()
+ df.collect()
Review Comment:
I tried it, and even if `df.collect()` is not executed, this test case can still pass. So, is it necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #44074:
URL: https://github.com/apache/spark/pull/44074#issuecomment-1833373932
thanks for review, merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1409598151
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala:
##########
@@ -149,6 +153,14 @@ class SparkSessionExtensions {
queryStageOptimizerRuleBuilders.map(_.apply(session)).toSeq
}
+ /**
+ * Build the override rules for the query post planner strategy phase of adaptive query execution.
+ */
+ private[sql] def buildQueryPostPlannerStrategyRules(
+ session: SparkSession): Seq[Rule[SparkPlan]] = {
+ queryPostPlannerStrategyRuleBuilders.map(_.apply(session)).toSeq
+ }
+
Review Comment:
ditto. Shall we put this before `private[sql] def buildQueryStagePrepRules`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46170][SQL] Support inject adaptive query post planner strategy rules in SparkSessionExtensions [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44074:
URL: https://github.com/apache/spark/pull/44074#discussion_r1409595327
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala:
##########
@@ -114,12 +115,15 @@ class SparkSessionExtensions {
type ColumnarRuleBuilder = SparkSession => ColumnarRule
type QueryStagePrepRuleBuilder = SparkSession => Rule[SparkPlan]
type QueryStageOptimizerRuleBuilder = SparkSession => Rule[SparkPlan]
+ type QueryPostPlannerStrategyBuilder = SparkSession => Rule[SparkPlan]
Review Comment:
Shall we put this before `type QueryStagePrepRuleBuilder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org