You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/04/21 23:10:12 UTC
[kudu-CR] [util] use include guard macro in int128.h header
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19783
Change subject: [util] use include guard macro in int128.h header
......................................................................
[util] use include guard macro in int128.h header
Even if '#pragma once' is supported by the vast majority of modern
compilers, it is a non-standard one [1]. The src/kudu/util/int128.h
file is included into other header files of the C++ Kudu client API,
which is supposed to be C++98 compliant. Since other header files
in the C++ client API are using include guard macros, let's use
the same technique for int128.h as well.
Doing so addresses a warning produced by the CLANG when running
client_examples_test.sh, while a standalone compilation is done on the
kudu/util/int128.h file:
#pragma once in main file [-Wpragma-once-outside-header]
[1] https://en.cppreference.com/w/cpp/preprocessor/impl
Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4
---
M src/kudu/util/int128.h
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/19783/1
--
To view, visit http://gerrit.cloudera.org:8080/19783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4
Gerrit-Change-Number: 19783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] use include guard macro in int128.h header
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [util] use include guard macro in int128.h header
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4
Gerrit-Change-Number: 19783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] use include guard macro in int128.h header
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19783 )
Change subject: [util] use include guard macro in int128.h header
......................................................................
Patch Set 1: Verified+1
unrelated test failure: SecurityComponentsFaultsITest.NoKdcOnStart
--
To view, visit http://gerrit.cloudera.org:8080/19783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4
Gerrit-Change-Number: 19783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 21 Apr 2023 23:55:41 +0000
Gerrit-HasComments: No
[kudu-CR] [util] use include guard macro in int128.h header
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19783 )
Change subject: [util] use include guard macro in int128.h header
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4
Gerrit-Change-Number: 19783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 21 Apr 2023 23:40:19 +0000
Gerrit-HasComments: No
[kudu-CR] [util] use include guard macro in int128.h header
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19783 )
Change subject: [util] use include guard macro in int128.h header
......................................................................
[util] use include guard macro in int128.h header
Even if '#pragma once' is supported by the vast majority of modern
compilers, it is a non-standard one [1]. The src/kudu/util/int128.h
file is included into other header files of the C++ Kudu client API,
which is supposed to be C++98 compliant. Since other header files
in the C++ client API are using include guard macros, let's use
the same technique for int128.h as well.
Doing so addresses a warning produced by the CLANG when running
client_examples_test.sh, while a standalone compilation is done on the
kudu/util/int128.h file:
#pragma once in main file [-Wpragma-once-outside-header]
[1] https://en.cppreference.com/w/cpp/preprocessor/impl
Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4
Reviewed-on: http://gerrit.cloudera.org:8080/19783
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/util/int128.h
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4
Gerrit-Change-Number: 19783
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)