[jira] [Commented] (CASSANDRA-14005) CqlBulkRecordWriter swallows exceptions

["Edward Ribeiro (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336589#comment-16336589 ] 

Edward Ribeiro commented on CASSANDRA-14005:
--------------------------------------------

Hi [~vdumont],

 

I have attached trivial proposal to this issue. Instead of swallowing the exception it logs the exception at the WARN level. As TimeOutExceptions are expected (and it will retry until it succeeds or fail) then I tried to log only ExecutionExceptions. I have based off this patch on cassandra-3.9 because you didn't provide a starting branch to apply the patch. Please, let me know what you think.

 

Cheers!

Ed

> CqlBulkRecordWriter swallows exceptions
> ---------------------------------------
>
>                 Key: CASSANDRA-14005
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14005
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL
>            Reporter: Vincent Dumont
>            Priority: Major
>         Attachments: CASSANDRA-14005.patch
>
>
> The {{close()}} method in {{CqlBulkRecordWriter}} has the following:
> {code:java}
>                 try
>                 {
>                     future.get(1000, TimeUnit.MILLISECONDS);
>                     break;
>                 }
>                 catch (ExecutionException | TimeoutException te)
>                 {
>                     if (null != progress)
>                         progress.progress();
>                     if (null != context)
>                         HadoopCompat.progress(context);
>                 }
>                 catch (InterruptedException e)
>                 {
>                     throw new IOException(e);
>                 }
> {code}
> And so any exception that happens when uploading SSTables silently gets swallowed and not surfaced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org