You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "magibney (via GitHub)" <gi...@apache.org> on 2024/12/18 16:51:10 UTC
[PR] SOLR-17597: Fix `CaffeineCache.put()` ramBytes decrement [solr]
magibney opened a new pull request, #2917:
URL: https://github.com/apache/solr/pull/2917
https://issues.apache.org/jira/browse/SOLR-17597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17597: Fix `CaffeineCache.put()` ramBytes decrement [solr]
Posted by "magibney (via GitHub)" <gi...@apache.org>.
magibney merged PR #2917:
URL: https://github.com/apache/solr/pull/2917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17597: Fix `CaffeineCache.put()` ramBytes decrement [solr]
Posted by "magibney (via GitHub)" <gi...@apache.org>.
magibney commented on PR #2917:
URL: https://github.com/apache/solr/pull/2917#issuecomment-2551828172
This probably does not warrant a CHANGES.txt entry, since it doesn't impact any existing/default implementation or invocation of `CaffeineCache`.
NOTE: the second (`V oldValue`) arg to the private method `CaffeineCache.recordRamBytes()` is always `null` as now invoked, and could be removed. I will remove this unless anyone objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17597: Fix `CaffeineCache.put()` ramBytes decrement [solr]
Posted by "magibney (via GitHub)" <gi...@apache.org>.
magibney commented on PR #2917:
URL: https://github.com/apache/solr/pull/2917#issuecomment-2551854131
This is a trivial change with no practical impact on the vast majority of users. I plan to merge this tomorrow, pending any feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org