You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/01 20:52:22 UTC

[GitHub] elibrumbaugh commented on issue #6745: Omnibar

elibrumbaugh commented on issue #6745: Omnibar
URL: https://github.com/apache/incubator-superset/pull/6745#issuecomment-459863802
 
 
   Hey @hughhhh this is a really neat idea!
   
   A few minor nits:
   
   1. Could we position the search field further down from the top of the screen. Ideally I think it would be centered in the current viewport.
   2. I don't think you need the .. after `Search for dashboards` placeholder text.
   3. Rephrasing that search prompt to `Search all dashboards` might be a little more clear.
   
   How does this handle unpublished dashboards if that PR goes in?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org