You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/17 01:40:16 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3468: [Enhancement] Make this method "synchronized" to match the parent class implementation.[ CloudEventTCPSubClient]

Alonexc opened a new issue, #3468:
URL: https://github.com/apache/incubator-eventmesh/issues/3468

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/225789763-cd14fe11-2fe9-426b-bab0-ab09bd484801.png)
   located at:
   eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/cloudevent/CloudEventTCPSubClient.java line 79
   analysis and explanation:
   When @Overrides of synchronized methods are not themselves synchronized, the result can be improper synchronization as callers rely on the thread-safety promised by the parent class.
   
   
   ### Describe the solution you'd like
   
   ![image](https://user-images.githubusercontent.com/91315508/225789799-aacbe732-ed3e-4f3b-ac6b-c0df24cd7b77.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


[GitHub] [eventmesh] pandaapo commented on issue #3468: [Enhancement] Make this method "synchronized" to match the parent class implementation.[CloudEventTCPSubClient]

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on issue #3468:
URL: https://github.com/apache/eventmesh/issues/3468#issuecomment-1518017593

   I have the same doubts about this issue as https://github.com/apache/eventmesh/issues/3470#issuecomment-1518007900


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


[GitHub] [eventmesh] Alonexc closed issue #3468: [Enhancement] Make this method "synchronized" to match the parent class implementation.[CloudEventTCPSubClient]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc closed issue #3468: [Enhancement] Make this method "synchronized" to match the parent class implementation.[CloudEventTCPSubClient]
URL: https://github.com/apache/eventmesh/issues/3468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org