You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/11/23 07:33:21 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #1538: [Enhancement] Method uses integer based for loops to iterate over a List [BatchMessage]
Alonexc opened a new issue, #1538:
URL: https://github.com/apache/incubator-eventmesh/issues/1538
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at: org/apache/eventmesh/common/protocol/grpc/protos/BatchMessage.java line 1664 and 1685
explanation:This method uses an integer-based for loop to iterate over a java.util.List, by calling List.get(i) each time through the loop. The integer is not used for other reasons. It is better to use an Iterator instead, as depending on List implementation, iterators can perform better, and they also allow for exchanging of other collection types without issue.
### Describe the solution you'd like
It is recommended to use iterators or foreach.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx closed issue #1538: [Enhancement] Method uses integer based for loops to iterate over a List [BatchMessage]
Posted by GitBox <gi...@apache.org>.
jonyangx closed issue #1538: [Enhancement] Method uses integer based for loops to iterate over a List [BatchMessage]
URL: https://github.com/apache/incubator-eventmesh/issues/1538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc closed issue #1538: [Enhancement] Method uses integer based for loops to iterate over a List [BatchMessage]
Posted by GitBox <gi...@apache.org>.
Alonexc closed issue #1538: [Enhancement] Method uses integer based for loops to iterate over a List [BatchMessage]
URL: https://github.com/apache/incubator-eventmesh/issues/1538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] karthiknatarajan-27558 commented on issue #1538: [Enhancement] Method uses integer based for loops to iterate over a List [BatchMessage]
Posted by GitBox <gi...@apache.org>.
karthiknatarajan-27558 commented on issue #1538:
URL: https://github.com/apache/incubator-eventmesh/issues/1538#issuecomment-1278482801
Hi @Alonexc ,
I would like to contribute to this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Orcohen33 commented on issue #1538: [Enhancement] Method uses integer based for loops to iterate over a List [BatchMessage]
Posted by GitBox <gi...@apache.org>.
Orcohen33 commented on issue #1538:
URL: https://github.com/apache/incubator-eventmesh/issues/1538#issuecomment-1382244153
I would like to contribute to this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #1538: [Enhancement] Method uses integer based for loops to iterate over a List [BatchMessage]
Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #1538:
URL: https://github.com/apache/incubator-eventmesh/issues/1538#issuecomment-1338655933
> Hi @Alonexc , I would like to contribute to this issue.
@LiuPiPiPi You can raise a pr to fix this issue, I don't have assigned permissions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] LiuPiPiPi commented on issue #1538: [Enhancement] Method uses integer based for loops to iterate over a List [BatchMessage]
Posted by GitBox <gi...@apache.org>.
LiuPiPiPi commented on issue #1538:
URL: https://github.com/apache/incubator-eventmesh/issues/1538#issuecomment-1327515038
Hi @Alonexc ,
I would like to contribute to this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org