You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/22 17:45:25 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #21877: AIP-45 Remove dag parsing in airflow run local

potiuk commented on a change in pull request #21877:
URL: https://github.com/apache/airflow/pull/21877#discussion_r832441243



##########
File path: airflow/jobs/local_task_job.py
##########
@@ -104,11 +104,6 @@ def signal_handler(signum, frame):
         try:
             self.task_runner.start()
 
-            # Unmap the task _after_ it has forked/execed. (This is a bit of a kludge, but if we unmap before

Review comment:
       Unless I am mistaken, I believe this was removed by mistake (and the next piece of code as well). Those two (unmap task and handling signals have been added recently so likely ths is caused by starting off from previous version and not realising the code is removed when rebasing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org