You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Igor Sapego <is...@apache.org> on 2018/10/09 15:31:33 UTC

Re: PHP thin client

As the seem to be everything OK with the code and tests and
no one had any comment for quite some time, I've merged the
PHP to Ignite's master.

Great job, guys!


Best Regards,
Igor


On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <pg...@gridgain.com> wrote:

> Hi Stephan, Alexey
>
> That's exactly what readme.io contains - installation instructions,
> configuration, and examples for key-value, sql, etc. for thin clients. For
> example, see these documentation pages for Node.js (currently hidden in the
> latest version of the doc) :
>
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
>
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
>
> This how Python and PHP thin clients will also be documented on readme.io
>
> -Prachi
>
>
>
>
> On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
> pilshchikov.s.n@gmail.com> wrote:
>
> > > You know, I'm confused with all this documentation stuff...
> > > For nodejs client all docs were moved from the repo to readme.io but
> > the
> > > readme.md keeps the installation instructions (duplicated with
> > > readme.io). Probably, that's ok.
> > > Will add similar short readme.md to the PHP PR.
> >
> > Its good
> >
> > What i think (and how it partially now):
> > All user documentation should be on readme.io (how to install, use it,
> > configurate, description for examples)
> > All developers documentation (how to release, how to start develop)
> and(!)
> > basic description should be in repository
> >
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >
>

Re: PHP thin client

Posted by Stepan Pilschikov <pi...@gmail.com>.

And more,

If im use  ->setValueType(ObjectType::ENUM) during $cache->get(1);
it throwing exception that client can't convert BINARY_ENUM to ENUM

вт, 23 окт. 2018 г. в 15:57, Stepan Pilschikov <pi...@gmail.com>:

> Thanks, finally fixes are merged
>
> I have new question
>
> I'm trying to put Enum object and get it back, but catch exception that
> enum is null
>
> code with output -
> https://gist.github.com/pilshchikov/b89c6e25f29da88ac03caa42231a02bc
>
> Also can't find Enum data type test in sources
>
> I trying to use Enum in a right way? If answer is Yes, can you please
> check this for yourself?
> I think its a bug
>
> вс, 21 окт. 2018 г. в 9:36, Pavel Petroshenko <pa...@petroshenko.com>:
>
>> Hi Stepan,
>>
>> I submitted a patch and updated JIRA with some comments. Can you please
>> give it a try?
>>
>> Thanks,
>> P.
>>
>>
>> On Fri, Oct 19, 2018 at 9:07 AM Stepan Pilschikov <
>> pilshchikov.s.n@gmail.com> wrote:
>>
>>> Alexey,
>>>
>>> Hi
>>>
>>> I'm trying to use PHP client for some times and discover one problem with
>>> DATA and TIMESTAMP data types
>>> I'ts appear when you trying to use DATA or TIMESTAMP as cache key
>>>
>>> All description in ticket:
>>> https://issues.apache.org/jira/browse/IGNITE-9951
>>>
>>> Can you help with that, please?
>>>
>>> чт, 11 окт. 2018 г. в 16:02, Igor Sapego <is...@apache.org>:
>>>
>>> > Alexey,
>>> >
>>> > Since PHP thin client is now in master, can you please add it to our
>>> > "Thin clients features" wiki page, so we can track the feature parity
>>> > of our clients?
>>> >
>>> > [1] -
>>> >
>>> https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features
>>> >
>>> > Best Regards,
>>> > Igor
>>> >
>>> >
>>> > On Wed, Oct 10, 2018 at 2:56 PM Vladimir Ozerov <vo...@gridgain.com>
>>> > wrote:
>>> >
>>> > > I am not sure there is an answer. This is just how we handled it
>>> before.
>>> > > IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
>>> > > several hours ago.
>>> > >
>>> > > On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego <is...@apache.org>
>>> wrote:
>>> > >
>>> > >> Vyacheslav,
>>> > >>
>>> > >> In this case, we should do the same with all existing doxygen
>>> > >> files, not only this one (see files with .dxg extension)
>>> > >>
>>> > >> Vova, Pavel,
>>> > >>
>>> > >> Were there historically any reasons to exclude doxygen files
>>> > >> from check instead of adding a license header?
>>> > >>
>>> > >> Best Regards,
>>> > >> Igor
>>> > >>
>>> > >>
>>> > >> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <
>>> daradurvs@gmail.com
>>> > >
>>> > >> wrote:
>>> > >>
>>> > >>> Great work guys, thanks!
>>> > >>>
>>> > >>> I've noticed TC fails in the build plan "Licenses Headers" which
>>> Igor
>>> > >>> have fixed already by excluding Doxyfile from checking.
>>> > >>>
>>> > >>> I've filled a ticket [1] and I'd suggest fixing the test in another
>>> > >>> way by adding the license header to Doxyfile.
>>> > >>>
>>> > >>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
>>> > >>>
>>> > >>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
>>> > >>> [2] https://github.com/apache/ignite/pull/4938/files
>>> > >>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
>>> > >>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <is...@apache.org>
>>> wrote:
>>> > >>> >
>>> > >>> > As the seem to be everything OK with the code and tests and
>>> > >>> > no one had any comment for quite some time, I've merged the
>>> > >>> > PHP to Ignite's master.
>>> > >>> >
>>> > >>> > Great job, guys!
>>> > >>> >
>>> > >>> >
>>> > >>> > Best Regards,
>>> > >>> > Igor
>>> > >>> >
>>> > >>> >
>>> > >>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <pg...@gridgain.com>
>>> > >>> wrote:
>>> > >>> >
>>> > >>> > > Hi Stephan, Alexey
>>> > >>> > >
>>> > >>> > > That's exactly what readme.io contains - installation
>>> > instructions,
>>> > >>> > > configuration, and examples for key-value, sql, etc. for thin
>>> > >>> clients. For
>>> > >>> > > example, see these documentation pages for Node.js (currently
>>> > hidden
>>> > >>> in the
>>> > >>> > > latest version of the doc) :
>>> > >>> > >
>>> > >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
>>> > >>> > >
>>> > >>> > >
>>> > >>>
>>> >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
>>> > >>> > >
>>> > >>>
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
>>> > >>> > >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
>>> > >>> > >
>>> > >>>
>>> >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
>>> > >>> > >
>>> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
>>> > >>> > >
>>> > >>> > > This how Python and PHP thin clients will also be documented on
>>> > >>> readme.io
>>> > >>> > >
>>> > >>> > > -Prachi
>>> > >>> > >
>>> > >>> > >
>>> > >>> > >
>>> > >>> > >
>>> > >>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
>>> > >>> > > pilshchikov.s.n@gmail.com> wrote:
>>> > >>> > >
>>> > >>> > > > > You know, I'm confused with all this documentation stuff...
>>> > >>> > > > > For nodejs client all docs were moved from the repo to
>>> > readme.io
>>> > >>> but
>>> > >>> > > > the
>>> > >>> > > > > readme.md keeps the installation instructions (duplicated
>>> with
>>> > >>> > > > > readme.io). Probably, that's ok.
>>> > >>> > > > > Will add similar short readme.md to the PHP PR.
>>> > >>> > > >
>>> > >>> > > > Its good
>>> > >>> > > >
>>> > >>> > > > What i think (and how it partially now):
>>> > >>> > > > All user documentation should be on readme.io (how to
>>> install,
>>> > >>> use it,
>>> > >>> > > > configurate, description for examples)
>>> > >>> > > > All developers documentation (how to release, how to start
>>> > develop)
>>> > >>> > > and(!)
>>> > >>> > > > basic description should be in repository
>>> > >>> > > >
>>> > >>> > > >
>>> > >>> > > >
>>> > >>> > > >
>>> > >>> > > > --
>>> > >>> > > > Sent from:
>>> > http://apache-ignite-developers.2346864.n4.nabble.com/
>>> > >>> > > >
>>> > >>> > >
>>> > >>>
>>> > >>>
>>> > >>>
>>> > >>> --
>>> > >>> Best Regards, Vyacheslav D.
>>> > >>>
>>> > >>
>>> >
>>>
>>

Re: PHP thin client

Posted by Stepan Pilschikov <pi...@gmail.com>.

Thanks, finally fixes are merged

I have new question

I'm trying to put Enum object and get it back, but catch exception that
enum is null

code with output -
https://gist.github.com/pilshchikov/b89c6e25f29da88ac03caa42231a02bc

Also can't find Enum data type test in sources

I trying to use Enum in a right way? If answer is Yes, can you please check
this for yourself?
I think its a bug

вс, 21 окт. 2018 г. в 9:36, Pavel Petroshenko <pa...@petroshenko.com>:

> Hi Stepan,
>
> I submitted a patch and updated JIRA with some comments. Can you please
> give it a try?
>
> Thanks,
> P.
>
>
> On Fri, Oct 19, 2018 at 9:07 AM Stepan Pilschikov <
> pilshchikov.s.n@gmail.com> wrote:
>
>> Alexey,
>>
>> Hi
>>
>> I'm trying to use PHP client for some times and discover one problem with
>> DATA and TIMESTAMP data types
>> I'ts appear when you trying to use DATA or TIMESTAMP as cache key
>>
>> All description in ticket:
>> https://issues.apache.org/jira/browse/IGNITE-9951
>>
>> Can you help with that, please?
>>
>> чт, 11 окт. 2018 г. в 16:02, Igor Sapego <is...@apache.org>:
>>
>> > Alexey,
>> >
>> > Since PHP thin client is now in master, can you please add it to our
>> > "Thin clients features" wiki page, so we can track the feature parity
>> > of our clients?
>> >
>> > [1] -
>> >
>> https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features
>> >
>> > Best Regards,
>> > Igor
>> >
>> >
>> > On Wed, Oct 10, 2018 at 2:56 PM Vladimir Ozerov <vo...@gridgain.com>
>> > wrote:
>> >
>> > > I am not sure there is an answer. This is just how we handled it
>> before.
>> > > IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
>> > > several hours ago.
>> > >
>> > > On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego <is...@apache.org>
>> wrote:
>> > >
>> > >> Vyacheslav,
>> > >>
>> > >> In this case, we should do the same with all existing doxygen
>> > >> files, not only this one (see files with .dxg extension)
>> > >>
>> > >> Vova, Pavel,
>> > >>
>> > >> Were there historically any reasons to exclude doxygen files
>> > >> from check instead of adding a license header?
>> > >>
>> > >> Best Regards,
>> > >> Igor
>> > >>
>> > >>
>> > >> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <
>> daradurvs@gmail.com
>> > >
>> > >> wrote:
>> > >>
>> > >>> Great work guys, thanks!
>> > >>>
>> > >>> I've noticed TC fails in the build plan "Licenses Headers" which
>> Igor
>> > >>> have fixed already by excluding Doxyfile from checking.
>> > >>>
>> > >>> I've filled a ticket [1] and I'd suggest fixing the test in another
>> > >>> way by adding the license header to Doxyfile.
>> > >>>
>> > >>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
>> > >>>
>> > >>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
>> > >>> [2] https://github.com/apache/ignite/pull/4938/files
>> > >>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
>> > >>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <is...@apache.org>
>> wrote:
>> > >>> >
>> > >>> > As the seem to be everything OK with the code and tests and
>> > >>> > no one had any comment for quite some time, I've merged the
>> > >>> > PHP to Ignite's master.
>> > >>> >
>> > >>> > Great job, guys!
>> > >>> >
>> > >>> >
>> > >>> > Best Regards,
>> > >>> > Igor
>> > >>> >
>> > >>> >
>> > >>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <pg...@gridgain.com>
>> > >>> wrote:
>> > >>> >
>> > >>> > > Hi Stephan, Alexey
>> > >>> > >
>> > >>> > > That's exactly what readme.io contains - installation
>> > instructions,
>> > >>> > > configuration, and examples for key-value, sql, etc. for thin
>> > >>> clients. For
>> > >>> > > example, see these documentation pages for Node.js (currently
>> > hidden
>> > >>> in the
>> > >>> > > latest version of the doc) :
>> > >>> > >
>> > >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
>> > >>> > >
>> > >>> > >
>> > >>>
>> >
>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
>> > >>> > >
>> > >>>
>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
>> > >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
>> > >>> > >
>> > >>>
>> >
>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
>> > >>> > >
>> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
>> > >>> > >
>> > >>> > > This how Python and PHP thin clients will also be documented on
>> > >>> readme.io
>> > >>> > >
>> > >>> > > -Prachi
>> > >>> > >
>> > >>> > >
>> > >>> > >
>> > >>> > >
>> > >>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
>> > >>> > > pilshchikov.s.n@gmail.com> wrote:
>> > >>> > >
>> > >>> > > > > You know, I'm confused with all this documentation stuff...
>> > >>> > > > > For nodejs client all docs were moved from the repo to
>> > readme.io
>> > >>> but
>> > >>> > > > the
>> > >>> > > > > readme.md keeps the installation instructions (duplicated
>> with
>> > >>> > > > > readme.io). Probably, that's ok.
>> > >>> > > > > Will add similar short readme.md to the PHP PR.
>> > >>> > > >
>> > >>> > > > Its good
>> > >>> > > >
>> > >>> > > > What i think (and how it partially now):
>> > >>> > > > All user documentation should be on readme.io (how to
>> install,
>> > >>> use it,
>> > >>> > > > configurate, description for examples)
>> > >>> > > > All developers documentation (how to release, how to start
>> > develop)
>> > >>> > > and(!)
>> > >>> > > > basic description should be in repository
>> > >>> > > >
>> > >>> > > >
>> > >>> > > >
>> > >>> > > >
>> > >>> > > > --
>> > >>> > > > Sent from:
>> > http://apache-ignite-developers.2346864.n4.nabble.com/
>> > >>> > > >
>> > >>> > >
>> > >>>
>> > >>>
>> > >>>
>> > >>> --
>> > >>> Best Regards, Vyacheslav D.
>> > >>>
>> > >>
>> >
>>
>

Re: PHP thin client

Posted by Pavel Petroshenko <pa...@petroshenko.com>.

Hi Stepan,

I submitted a patch and updated JIRA with some comments. Can you please
give it a try?

Thanks,
P.


On Fri, Oct 19, 2018 at 9:07 AM Stepan Pilschikov <pi...@gmail.com>
wrote:

> Alexey,
>
> Hi
>
> I'm trying to use PHP client for some times and discover one problem with
> DATA and TIMESTAMP data types
> I'ts appear when you trying to use DATA or TIMESTAMP as cache key
>
> All description in ticket:
> https://issues.apache.org/jira/browse/IGNITE-9951
>
> Can you help with that, please?
>
> чт, 11 окт. 2018 г. в 16:02, Igor Sapego <is...@apache.org>:
>
> > Alexey,
> >
> > Since PHP thin client is now in master, can you please add it to our
> > "Thin clients features" wiki page, so we can track the feature parity
> > of our clients?
> >
> > [1] -
> > https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features
> >
> > Best Regards,
> > Igor
> >
> >
> > On Wed, Oct 10, 2018 at 2:56 PM Vladimir Ozerov <vo...@gridgain.com>
> > wrote:
> >
> > > I am not sure there is an answer. This is just how we handled it
> before.
> > > IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
> > > several hours ago.
> > >
> > > On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego <is...@apache.org>
> wrote:
> > >
> > >> Vyacheslav,
> > >>
> > >> In this case, we should do the same with all existing doxygen
> > >> files, not only this one (see files with .dxg extension)
> > >>
> > >> Vova, Pavel,
> > >>
> > >> Were there historically any reasons to exclude doxygen files
> > >> from check instead of adding a license header?
> > >>
> > >> Best Regards,
> > >> Igor
> > >>
> > >>
> > >> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <
> daradurvs@gmail.com
> > >
> > >> wrote:
> > >>
> > >>> Great work guys, thanks!
> > >>>
> > >>> I've noticed TC fails in the build plan "Licenses Headers" which Igor
> > >>> have fixed already by excluding Doxyfile from checking.
> > >>>
> > >>> I've filled a ticket [1] and I'd suggest fixing the test in another
> > >>> way by adding the license header to Doxyfile.
> > >>>
> > >>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
> > >>>
> > >>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
> > >>> [2] https://github.com/apache/ignite/pull/4938/files
> > >>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
> > >>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <is...@apache.org>
> wrote:
> > >>> >
> > >>> > As the seem to be everything OK with the code and tests and
> > >>> > no one had any comment for quite some time, I've merged the
> > >>> > PHP to Ignite's master.
> > >>> >
> > >>> > Great job, guys!
> > >>> >
> > >>> >
> > >>> > Best Regards,
> > >>> > Igor
> > >>> >
> > >>> >
> > >>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <pg...@gridgain.com>
> > >>> wrote:
> > >>> >
> > >>> > > Hi Stephan, Alexey
> > >>> > >
> > >>> > > That's exactly what readme.io contains - installation
> > instructions,
> > >>> > > configuration, and examples for key-value, sql, etc. for thin
> > >>> clients. For
> > >>> > > example, see these documentation pages for Node.js (currently
> > hidden
> > >>> in the
> > >>> > > latest version of the doc) :
> > >>> > >
> > >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
> > >>> > >
> > >>> > >
> > >>>
> >
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
> > >>> > >
> > >>>
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
> > >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
> > >>> > >
> > >>>
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
> > >>> > >
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
> > >>> > >
> > >>> > > This how Python and PHP thin clients will also be documented on
> > >>> readme.io
> > >>> > >
> > >>> > > -Prachi
> > >>> > >
> > >>> > >
> > >>> > >
> > >>> > >
> > >>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
> > >>> > > pilshchikov.s.n@gmail.com> wrote:
> > >>> > >
> > >>> > > > > You know, I'm confused with all this documentation stuff...
> > >>> > > > > For nodejs client all docs were moved from the repo to
> > readme.io
> > >>> but
> > >>> > > > the
> > >>> > > > > readme.md keeps the installation instructions (duplicated
> with
> > >>> > > > > readme.io). Probably, that's ok.
> > >>> > > > > Will add similar short readme.md to the PHP PR.
> > >>> > > >
> > >>> > > > Its good
> > >>> > > >
> > >>> > > > What i think (and how it partially now):
> > >>> > > > All user documentation should be on readme.io (how to install,
> > >>> use it,
> > >>> > > > configurate, description for examples)
> > >>> > > > All developers documentation (how to release, how to start
> > develop)
> > >>> > > and(!)
> > >>> > > > basic description should be in repository
> > >>> > > >
> > >>> > > >
> > >>> > > >
> > >>> > > >
> > >>> > > > --
> > >>> > > > Sent from:
> > http://apache-ignite-developers.2346864.n4.nabble.com/
> > >>> > > >
> > >>> > >
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Best Regards, Vyacheslav D.
> > >>>
> > >>
> >
>

Re: PHP thin client

Posted by Stepan Pilschikov <pi...@gmail.com>.

Alexey,

Hi

I'm trying to use PHP client for some times and discover one problem with
DATA and TIMESTAMP data types
I'ts appear when you trying to use DATA or TIMESTAMP as cache key

All description in ticket:
https://issues.apache.org/jira/browse/IGNITE-9951

Can you help with that, please?

чт, 11 окт. 2018 г. в 16:02, Igor Sapego <is...@apache.org>:

> Alexey,
>
> Since PHP thin client is now in master, can you please add it to our
> "Thin clients features" wiki page, so we can track the feature parity
> of our clients?
>
> [1] -
> https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features
>
> Best Regards,
> Igor
>
>
> On Wed, Oct 10, 2018 at 2:56 PM Vladimir Ozerov <vo...@gridgain.com>
> wrote:
>
> > I am not sure there is an answer. This is just how we handled it before.
> > IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
> > several hours ago.
> >
> > On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego <is...@apache.org> wrote:
> >
> >> Vyacheslav,
> >>
> >> In this case, we should do the same with all existing doxygen
> >> files, not only this one (see files with .dxg extension)
> >>
> >> Vova, Pavel,
> >>
> >> Were there historically any reasons to exclude doxygen files
> >> from check instead of adding a license header?
> >>
> >> Best Regards,
> >> Igor
> >>
> >>
> >> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <daradurvs@gmail.com
> >
> >> wrote:
> >>
> >>> Great work guys, thanks!
> >>>
> >>> I've noticed TC fails in the build plan "Licenses Headers" which Igor
> >>> have fixed already by excluding Doxyfile from checking.
> >>>
> >>> I've filled a ticket [1] and I'd suggest fixing the test in another
> >>> way by adding the license header to Doxyfile.
> >>>
> >>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
> >>>
> >>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
> >>> [2] https://github.com/apache/ignite/pull/4938/files
> >>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
> >>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <is...@apache.org> wrote:
> >>> >
> >>> > As the seem to be everything OK with the code and tests and
> >>> > no one had any comment for quite some time, I've merged the
> >>> > PHP to Ignite's master.
> >>> >
> >>> > Great job, guys!
> >>> >
> >>> >
> >>> > Best Regards,
> >>> > Igor
> >>> >
> >>> >
> >>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <pg...@gridgain.com>
> >>> wrote:
> >>> >
> >>> > > Hi Stephan, Alexey
> >>> > >
> >>> > > That's exactly what readme.io contains - installation
> instructions,
> >>> > > configuration, and examples for key-value, sql, etc. for thin
> >>> clients. For
> >>> > > example, see these documentation pages for Node.js (currently
> hidden
> >>> in the
> >>> > > latest version of the doc) :
> >>> > >
> >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
> >>> > >
> >>> > >
> >>>
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
> >>> > >
> >>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
> >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
> >>> > >
> >>>
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
> >>> > >
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
> >>> > >
> >>> > > This how Python and PHP thin clients will also be documented on
> >>> readme.io
> >>> > >
> >>> > > -Prachi
> >>> > >
> >>> > >
> >>> > >
> >>> > >
> >>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
> >>> > > pilshchikov.s.n@gmail.com> wrote:
> >>> > >
> >>> > > > > You know, I'm confused with all this documentation stuff...
> >>> > > > > For nodejs client all docs were moved from the repo to
> readme.io
> >>> but
> >>> > > > the
> >>> > > > > readme.md keeps the installation instructions (duplicated with
> >>> > > > > readme.io). Probably, that's ok.
> >>> > > > > Will add similar short readme.md to the PHP PR.
> >>> > > >
> >>> > > > Its good
> >>> > > >
> >>> > > > What i think (and how it partially now):
> >>> > > > All user documentation should be on readme.io (how to install,
> >>> use it,
> >>> > > > configurate, description for examples)
> >>> > > > All developers documentation (how to release, how to start
> develop)
> >>> > > and(!)
> >>> > > > basic description should be in repository
> >>> > > >
> >>> > > >
> >>> > > >
> >>> > > >
> >>> > > > --
> >>> > > > Sent from:
> http://apache-ignite-developers.2346864.n4.nabble.com/
> >>> > > >
> >>> > >
> >>>
> >>>
> >>>
> >>> --
> >>> Best Regards, Vyacheslav D.
> >>>
> >>
>

Re: PHP thin client

Posted by Igor Sapego <is...@apache.org>.

Alexey,

Since PHP thin client is now in master, can you please add it to our
"Thin clients features" wiki page, so we can track the feature parity
of our clients?

[1] -
https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features

Best Regards,
Igor


On Wed, Oct 10, 2018 at 2:56 PM Vladimir Ozerov <vo...@gridgain.com>
wrote:

> I am not sure there is an answer. This is just how we handled it before.
> IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
> several hours ago.
>
> On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego <is...@apache.org> wrote:
>
>> Vyacheslav,
>>
>> In this case, we should do the same with all existing doxygen
>> files, not only this one (see files with .dxg extension)
>>
>> Vova, Pavel,
>>
>> Were there historically any reasons to exclude doxygen files
>> from check instead of adding a license header?
>>
>> Best Regards,
>> Igor
>>
>>
>> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <da...@gmail.com>
>> wrote:
>>
>>> Great work guys, thanks!
>>>
>>> I've noticed TC fails in the build plan "Licenses Headers" which Igor
>>> have fixed already by excluding Doxyfile from checking.
>>>
>>> I've filled a ticket [1] and I'd suggest fixing the test in another
>>> way by adding the license header to Doxyfile.
>>>
>>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
>>>
>>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
>>> [2] https://github.com/apache/ignite/pull/4938/files
>>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
>>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <is...@apache.org> wrote:
>>> >
>>> > As the seem to be everything OK with the code and tests and
>>> > no one had any comment for quite some time, I've merged the
>>> > PHP to Ignite's master.
>>> >
>>> > Great job, guys!
>>> >
>>> >
>>> > Best Regards,
>>> > Igor
>>> >
>>> >
>>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <pg...@gridgain.com>
>>> wrote:
>>> >
>>> > > Hi Stephan, Alexey
>>> > >
>>> > > That's exactly what readme.io contains - installation instructions,
>>> > > configuration, and examples for key-value, sql, etc. for thin
>>> clients. For
>>> > > example, see these documentation pages for Node.js (currently hidden
>>> in the
>>> > > latest version of the doc) :
>>> > >
>>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
>>> > >
>>> > >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
>>> > >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
>>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
>>> > >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
>>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
>>> > >
>>> > > This how Python and PHP thin clients will also be documented on
>>> readme.io
>>> > >
>>> > > -Prachi
>>> > >
>>> > >
>>> > >
>>> > >
>>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
>>> > > pilshchikov.s.n@gmail.com> wrote:
>>> > >
>>> > > > > You know, I'm confused with all this documentation stuff...
>>> > > > > For nodejs client all docs were moved from the repo to readme.io
>>> but
>>> > > > the
>>> > > > > readme.md keeps the installation instructions (duplicated with
>>> > > > > readme.io). Probably, that's ok.
>>> > > > > Will add similar short readme.md to the PHP PR.
>>> > > >
>>> > > > Its good
>>> > > >
>>> > > > What i think (and how it partially now):
>>> > > > All user documentation should be on readme.io (how to install,
>>> use it,
>>> > > > configurate, description for examples)
>>> > > > All developers documentation (how to release, how to start develop)
>>> > > and(!)
>>> > > > basic description should be in repository
>>> > > >
>>> > > >
>>> > > >
>>> > > >
>>> > > > --
>>> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>>> > > >
>>> > >
>>>
>>>
>>>
>>> --
>>> Best Regards, Vyacheslav D.
>>>
>>

Re: PHP thin client

Posted by Vladimir Ozerov <vo...@gridgain.com>.

I am not sure there is an answer. This is just how we handled it before.
IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
several hours ago.

On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego <is...@apache.org> wrote:

> Vyacheslav,
>
> In this case, we should do the same with all existing doxygen
> files, not only this one (see files with .dxg extension)
>
> Vova, Pavel,
>
> Were there historically any reasons to exclude doxygen files
> from check instead of adding a license header?
>
> Best Regards,
> Igor
>
>
> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <da...@gmail.com>
> wrote:
>
>> Great work guys, thanks!
>>
>> I've noticed TC fails in the build plan "Licenses Headers" which Igor
>> have fixed already by excluding Doxyfile from checking.
>>
>> I've filled a ticket [1] and I'd suggest fixing the test in another
>> way by adding the license header to Doxyfile.
>>
>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
>>
>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
>> [2] https://github.com/apache/ignite/pull/4938/files
>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <is...@apache.org> wrote:
>> >
>> > As the seem to be everything OK with the code and tests and
>> > no one had any comment for quite some time, I've merged the
>> > PHP to Ignite's master.
>> >
>> > Great job, guys!
>> >
>> >
>> > Best Regards,
>> > Igor
>> >
>> >
>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <pg...@gridgain.com> wrote:
>> >
>> > > Hi Stephan, Alexey
>> > >
>> > > That's exactly what readme.io contains - installation instructions,
>> > > configuration, and examples for key-value, sql, etc. for thin
>> clients. For
>> > > example, see these documentation pages for Node.js (currently hidden
>> in the
>> > > latest version of the doc) :
>> > >
>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
>> > >
>> > >
>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
>> > >
>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
>> > >
>> > > This how Python and PHP thin clients will also be documented on
>> readme.io
>> > >
>> > > -Prachi
>> > >
>> > >
>> > >
>> > >
>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
>> > > pilshchikov.s.n@gmail.com> wrote:
>> > >
>> > > > > You know, I'm confused with all this documentation stuff...
>> > > > > For nodejs client all docs were moved from the repo to readme.io
>> but
>> > > > the
>> > > > > readme.md keeps the installation instructions (duplicated with
>> > > > > readme.io). Probably, that's ok.
>> > > > > Will add similar short readme.md to the PHP PR.
>> > > >
>> > > > Its good
>> > > >
>> > > > What i think (and how it partially now):
>> > > > All user documentation should be on readme.io (how to install, use
>> it,
>> > > > configurate, description for examples)
>> > > > All developers documentation (how to release, how to start develop)
>> > > and(!)
>> > > > basic description should be in repository
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>> > > >
>> > >
>>
>>
>>
>> --
>> Best Regards, Vyacheslav D.
>>
>

Re: PHP thin client

Posted by Igor Sapego <is...@apache.org>.

Vyacheslav,

In this case, we should do the same with all existing doxygen
files, not only this one (see files with .dxg extension)

Vova, Pavel,

Were there historically any reasons to exclude doxygen files
from check instead of adding a license header?

Best Regards,
Igor


On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <da...@gmail.com>
wrote:

> Great work guys, thanks!
>
> I've noticed TC fails in the build plan "Licenses Headers" which Igor
> have fixed already by excluding Doxyfile from checking.
>
> I've filled a ticket [1] and I'd suggest fixing the test in another
> way by adding the license header to Doxyfile.
>
> Igor, please, have a look at prepared PR [2] (tests passed [3]).
>
> [1] https://issues.apache.org/jira/browse/IGNITE-9832
> [2] https://github.com/apache/ignite/pull/4938/files
> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <is...@apache.org> wrote:
> >
> > As the seem to be everything OK with the code and tests and
> > no one had any comment for quite some time, I've merged the
> > PHP to Ignite's master.
> >
> > Great job, guys!
> >
> >
> > Best Regards,
> > Igor
> >
> >
> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <pg...@gridgain.com> wrote:
> >
> > > Hi Stephan, Alexey
> > >
> > > That's exactly what readme.io contains - installation instructions,
> > > configuration, and examples for key-value, sql, etc. for thin clients.
> For
> > > example, see these documentation pages for Node.js (currently hidden
> in the
> > > latest version of the doc) :
> > >
> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
> > >
> > >
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
> > >
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
> > >
> > > This how Python and PHP thin clients will also be documented on
> readme.io
> > >
> > > -Prachi
> > >
> > >
> > >
> > >
> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
> > > pilshchikov.s.n@gmail.com> wrote:
> > >
> > > > > You know, I'm confused with all this documentation stuff...
> > > > > For nodejs client all docs were moved from the repo to readme.io
> but
> > > > the
> > > > > readme.md keeps the installation instructions (duplicated with
> > > > > readme.io). Probably, that's ok.
> > > > > Will add similar short readme.md to the PHP PR.
> > > >
> > > > Its good
> > > >
> > > > What i think (and how it partially now):
> > > > All user documentation should be on readme.io (how to install, use
> it,
> > > > configurate, description for examples)
> > > > All developers documentation (how to release, how to start develop)
> > > and(!)
> > > > basic description should be in repository
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> > > >
> > >
>
>
>
> --
> Best Regards, Vyacheslav D.
>

Re: PHP thin client

Posted by Vyacheslav Daradur <da...@gmail.com>.

Great work guys, thanks!

I've noticed TC fails in the build plan "Licenses Headers" which Igor
have fixed already by excluding Doxyfile from checking.

I've filled a ticket [1] and I'd suggest fixing the test in another
way by adding the license header to Doxyfile.

Igor, please, have a look at prepared PR [2] (tests passed [3]).

[1] https://issues.apache.org/jira/browse/IGNITE-9832
[2] https://github.com/apache/ignite/pull/4938/files
[3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <is...@apache.org> wrote:
>
> As the seem to be everything OK with the code and tests and
> no one had any comment for quite some time, I've merged the
> PHP to Ignite's master.
>
> Great job, guys!
>
>
> Best Regards,
> Igor
>
>
> On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <pg...@gridgain.com> wrote:
>
> > Hi Stephan, Alexey
> >
> > That's exactly what readme.io contains - installation instructions,
> > configuration, and examples for key-value, sql, etc. for thin clients. For
> > example, see these documentation pages for Node.js (currently hidden in the
> > latest version of the doc) :
> >
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
> >
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
> >
> > This how Python and PHP thin clients will also be documented on readme.io
> >
> > -Prachi
> >
> >
> >
> >
> > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
> > pilshchikov.s.n@gmail.com> wrote:
> >
> > > > You know, I'm confused with all this documentation stuff...
> > > > For nodejs client all docs were moved from the repo to readme.io but
> > > the
> > > > readme.md keeps the installation instructions (duplicated with
> > > > readme.io). Probably, that's ok.
> > > > Will add similar short readme.md to the PHP PR.
> > >
> > > Its good
> > >
> > > What i think (and how it partially now):
> > > All user documentation should be on readme.io (how to install, use it,
> > > configurate, description for examples)
> > > All developers documentation (how to release, how to start develop)
> > and(!)
> > > basic description should be in repository
> > >
> > >
> > >
> > >
> > > --
> > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> > >
> >



-- 
Best Regards, Vyacheslav D.